Remove comment about hardcoded id

joto · joto · commit 22dbf089640e · 2023-07-09T09:39:00.000+02:00
We only every use the name "id" for the middle tables, so it's totally
fine that this is hardcoded here.
diff --git a/src/middle-pgsql.cpp b/src/middle-pgsql.cpp
@@ -86,7 +86,7 @@ middle_pgsql_t::table_desc::table_desc(options_t const &options,
 {
     m_copy_target->name = build_sql(options, ts.name);
     m_copy_target->schema = options.middle_dbschema;
-    m_copy_target->id = "id"; // XXX hardcoded column name
+    m_copy_target->id = "id";
 
     if (options.with_forward_dependencies) {
         m_prepare_fw_dep_lookups =

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ middle_pgsql_t::table_desc::table_desc(options_t const &options,`
`86`	`86`	`{`
`87`	`87`	`m_copy_target->name = build_sql(options, ts.name);`
`88`	`88`	`m_copy_target->schema = options.middle_dbschema;`
`89`		`- m_copy_target->id = "id"; // XXX hardcoded column name`
	`89`	`+ m_copy_target->id = "id";`
`90`	`90`
`91`	`91`	`if (options.with_forward_dependencies) {`
`92`	`92`	`m_prepare_fw_dep_lookups =`