disallow empty string for baggage name (#1484)

brettmc · web-flow · commit 7b194e3c515a · 2025-01-30T08:38:08.000+11:00
spec 1.36.0 clarifies that empty string is not a valid baggage name
diff --git a/Baggage/BaggageBuilder.php b/Baggage/BaggageBuilder.php
@@ -22,6 +22,9 @@ public function remove(string $key): BaggageBuilderInterface
     /** @inheritDoc */
     public function set(string $key, $value, ?MetadataInterface $metadata = null): BaggageBuilderInterface
     {
+        if ($key === '') {
+            return $this;
+        }
         $metadata ??= Metadata::getEmpty();
 
         $this->entries[$key] = new Entry($value, $metadata);

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,9 @@ public function remove(string $key): BaggageBuilderInterface`
`22`	`22`	`/** @inheritDoc */`
`23`	`23`	`public function set(string $key, $value, ?MetadataInterface $metadata = null): BaggageBuilderInterface`
`24`	`24`	`{`
	`25`	`+ if ($key === '') {`
	`26`	`+ return $this;`
	`27`	`+ }`
`25`	`28`	`$metadata ??= Metadata::getEmpty();`
`26`	`29`
`27`	`30`	`$this->entries[$key] = new Entry($value, $metadata);`