Merge pull request #30902 from openshift-cherrypick-robot/cherry-pick-30872-to-release-4.21

[release-4.21] OCPBUGS-78780: changed http to https for three places to reduce test false positives and false negatives

Author: openshift-merge-bot[bot]

pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go

@@ -20,7 +20,7 @@ const (
 	newConnectionTestName    = "[sig-trt] disruption/ci-cluster-network-liveness connection/new should be available throughout the test"
 	reusedConnectionTestName = "[sig-trt] disruption/ci-cluster-network-liveness connection/reused should be available throughout the test"
 
-	externalServiceURL = "http://static.redhat.com/test/rhel-networkmanager.txt"
+	externalServiceURL = "https://static.redhat.com/test/rhel-networkmanager.txt"
 )
 
 type availability struct {

test/extended/machine_config/helpers.go

@@ -129,7 +129,7 @@ func IsTwoNodeArbiter(oc *exutil.CLI) bool {
 
 // `IsDisconnected` returns true if the cluster is a Disconnected cluster and false otherwise
 func IsDisconnected(oc *exutil.CLI, nodeName string) bool {
-	networkStatus, _ := exutil.DebugNodeRetryWithOptionsAndChroot(oc, nodeName, "openshift-machine-config-operator", "sh", "-c", "curl -s --connect-timeout 5 http://fedoraproject.org/static/hotspot.txt &>/dev/null && echo \"Connected\" || echo \"Disconnected\"")
+	networkStatus, _ := exutil.DebugNodeRetryWithOptionsAndChroot(oc, nodeName, "openshift-machine-config-operator", "sh", "-c", "curl -s --connect-timeout 5 https://fedoraproject.org/static/hotspot.txt &>/dev/null && echo \"Connected\" || echo \"Disconnected\"")
 	if networkStatus == "Connected" {
 		return false
 	}

test/extended/networking/egress_firewall.go

@@ -183,7 +183,7 @@ func sendEgressFwTraffic(f *e2e.Framework, mgmtFw *e2e.Framework, oc *exutil.CLI
 	// Test curl to www.redhat.com should fail
 	// because we don't have allow dns rule for www.redhat.com
 	g.By("sending traffic that does not match allow dns rule")
-	_, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "http://www.redhat.com").Output()
+	_, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "https://www.redhat.com").Output()
 	expectError(err)
 
 	if nodeSelectorSupport {