s3 mirrors should not error parsing repository name

The semi-recent change to force canonical parsing incorrectly broke
this code path. While we are in here, clean up the client invocations,
correctly support ~/.aws/credentials, and add better debugging info.
Also, the WithDescriptor() option is required for creation so ensure
it is always set.

Author: smarterclayton

pkg/oc/cli/image/mirror/mirror.go

@@ -44,7 +44,8 @@ var (
 		blobs (instead of uploading). The source bucket also supports the suffix "/[store]", which
 		will transform blob identifiers into the form the Docker registry uses on disk, allowing
 		you to mirror directly from an existing S3-backed Docker registry. Credentials for S3
-		may be stored in your docker credential file and looked up by host.
+		may be stored in your docker credential file and looked up by host, or loaded via the normal
+		AWS client locations for ENV or file.
 
 		Images in manifest list format will be copied as-is unless you use --filter-by-os to restrict
 		the allowed images to copy in a manifest list. This flag has no effect on regular images.
@@ -542,6 +543,10 @@ func copyBlob(ctx context.Context, plan *workPlan, c *repositoryBlobCopy, blob d
 		return nil
 	}
 
+	if c.destinationType == DestinationS3 {
+		options = append(options, WithDescriptor(blob))
+	}
+
 	w, err := c.to.Create(ctx, options...)
 	// no-op
 	if err == ErrAlreadyExists {

pkg/oc/cli/image/mirror/s3.go

@@ -73,14 +73,19 @@ func (d *s3Driver) newObject(server *url.URL, region string, insecure bool, secu
 	creds = credentials.NewChainCredentials([]credentials.Provider{
 		&s3CredentialStore{store: d.Creds, url: securityDomain},
 		&credentials.EnvProvider{},
+		&credentials.SharedCredentialsProvider{},
 	})
 
-	awsConfig.WithS3ForcePathStyle(true)
-	awsConfig.WithEndpoint(server.String())
 	awsConfig.WithCredentials(creds)
 	awsConfig.WithRegion(region)
 	awsConfig.WithDisableSSL(insecure)
-	if klog.V(6) {
+
+	switch {
+	case bool(klog.V(10)):
+		awsConfig.WithLogLevel(aws.LogDebugWithHTTPBody | aws.LogDebugWithRequestErrors | aws.LogDebugWithSigning)
+	case bool(klog.V(8)):
+		awsConfig.WithLogLevel(aws.LogDebugWithRequestErrors)
+	case bool(klog.V(6)):
 		awsConfig.WithLogLevel(aws.LogDebug)
 	}
 
@@ -110,10 +115,16 @@ func (d *s3Driver) Repository(ctx context.Context, server *url.URL, repoName str
 	if err != nil {
 		return nil, err
 	}
-	named, err := reference.ParseNamed(parts[2])
+
+	ref, err := reference.Parse(parts[2])
 	if err != nil {
 		return nil, err
 	}
+	named, ok := ref.(reference.Named)
+	if !ok {
+		return nil, fmt.Errorf("%s is not a valid repository name", parts[2])
+	}
+
 	repo := &s3Repository{
 		ctx:      ctx,
 		s3:       s3obj,