Skip to content

Commit d399ee7

Browse files
Jascha Franklin-Hodgehunterowens
authored andcommitted
Add impacts on implementors to the definition of breaking changes.
1 parent ffffed0 commit d399ee7

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/ISSUE_TEMPLATE/feature-request---proposal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ A clear and concise description of what the problem is. Ex. I'm always frustrate
1414
A clear and concise description of what you want to happen.
1515

1616
**Is this a breaking change**
17-
A breaking change would require consumers of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
17+
A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
1818

1919
[ ] Yes, breaking
2020
[ ] No, not breaking

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Please provide a clear and concise reason for this pull request and the impact of the change
33

44
**Is this a breaking change**
5-
A breaking change would require consumers of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
5+
A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
66

77
[ ] Yes, breaking
88
[ ] No, not breaking

0 commit comments

Comments
 (0)