refactor definition name to module-level variable

transition consumers to load the definition by name instead of making
another function call to mds_feature_point_definition

Author: thekaveman

schema/common.py

@@ -11,6 +11,9 @@
 COMMON_DEFINITIONS = {}
 
 
+MDS_FEATURE_POINT = "MDS_Feature_Point"
+
+
 def load_json(path):
     """
     Load a JSON file from disk.
@@ -132,14 +135,12 @@ def mds_feature_point_definition():
     """
     Create a customized definition of the GeoJSON Feature schema for MDS Points.
     """
-    name = "MDS_Feature_Point"
-
     # Get the canonical Feature schema
     feature = requests.get("http://geojson.org/schema/Feature.json").json()
 
     # Modify metadata
     feature.pop("$schema")
-    feature["$id"] = definition_id(name)
+    feature["$id"] = definition_id(MDS_FEATURE_POINT)
     feature["title"] = "MDS GeoJSON Feature Point"
 
     # Only allow GeoJSON Point feature geometry
@@ -163,7 +164,7 @@ def mds_feature_point_definition():
         }
     }
 
-    return {name: feature}
+    return {MDS_FEATURE_POINT: feature}
 
 
 def stop_definitions():
@@ -177,9 +178,9 @@ def stop_definitions():
         "timestamp",
         "uuid",
         "uuid_array",
-        "vehicle_type_counts"
+        "vehicle_type_counts",
+        MDS_FEATURE_POINT
     )
-    definitions.update(mds_feature_point_definition())
 
     return definitions
 

schema/provider.py

@@ -48,10 +48,10 @@ def endpoint_schema(endpoint, extra_definitions={}):
         "string",
         "timestamp",
         "uuid",
-        "version"
+        "version",
+        common.MDS_FEATURE_POINT
     )
     definitions.update(common.point_definition())
-    definitions.update(common.mds_feature_point_definition())
     definitions.update(extra_definitions)
 
     endpoint_schema = common.load_json(f"./templates/provider/{endpoint}.json")