Skip to content

Commit c17704e

Browse files
authored
Remove tests which only test scikit-learn functionality (#1169)
We should only test code that we write.
1 parent 2ddae0f commit c17704e

1 file changed

Lines changed: 0 additions & 30 deletions

File tree

tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1304,36 +1304,6 @@ def test_illegal_parameter_names(self):
13041304
for case in cases:
13051305
self.assertRaises(PyOpenMLError, self.extension.model_to_flow, case)
13061306

1307-
def test_illegal_parameter_names_pipeline(self):
1308-
# illegal name: steps
1309-
steps = [
1310-
("Imputer", SimpleImputer(strategy="median")),
1311-
(
1312-
"OneHotEncoder",
1313-
sklearn.preprocessing.OneHotEncoder(sparse=False, handle_unknown="ignore"),
1314-
),
1315-
(
1316-
"steps",
1317-
sklearn.ensemble.BaggingClassifier(
1318-
base_estimator=sklearn.tree.DecisionTreeClassifier
1319-
),
1320-
),
1321-
]
1322-
self.assertRaises(ValueError, sklearn.pipeline.Pipeline, steps=steps)
1323-
1324-
def test_illegal_parameter_names_featureunion(self):
1325-
# illegal name: transformer_list
1326-
transformer_list = [
1327-
("transformer_list", SimpleImputer(strategy="median")),
1328-
(
1329-
"OneHotEncoder",
1330-
sklearn.preprocessing.OneHotEncoder(sparse=False, handle_unknown="ignore"),
1331-
),
1332-
]
1333-
self.assertRaises(
1334-
ValueError, sklearn.pipeline.FeatureUnion, transformer_list=transformer_list
1335-
)
1336-
13371307
def test_paralizable_check(self):
13381308
# using this model should pass the test (if param distribution is
13391309
# legal)

0 commit comments

Comments
 (0)