FIX _check_flow_exists

Author: mfeurer

openml/flows/flow.py

@@ -375,9 +375,7 @@ def _ensure_flow_exists(self):
         flow_id : int
             Flow id on the server.
         """
-        import sklearn
-        flow_version = 'sklearn_' + sklearn.__version__
-        _, _, flow_id = _check_flow_exists(self.name, flow_version)
+        _, _, flow_id = _check_flow_exists(self.name, self.external_version)
         # TODO add numpy and scipy version!
 
         if int(flow_id) == -1:
@@ -413,7 +411,6 @@ def _check_flow_exists(name, version):
 
     return_code, xml_response = _perform_api_call(
         "flow/exists/%s/%s" % (name, version))
-    print(return_code)
     # TODO check with latest version of code if this raises an exception
     if return_code != 200:
         # fixme raise appropriate error

tests/flows/test_flow.py

@@ -21,6 +21,7 @@
 from openml.testing import TestBase
 from openml._api_calls import _perform_api_call
 import openml
+from openml.flows.sklearn_converter import _format_external_version
 
 
 def get_sentinel():
@@ -121,7 +122,8 @@ def test_publish_flow(self):
                                  components=collections.OrderedDict(),
                                  parameters=collections.OrderedDict(),
                                  parameters_meta_info=collections.OrderedDict(),
-                                 external_version=str(sklearn.__version__),
+                                 external_version=_format_external_version(
+                                     'sklearn', sklearn.__version__),
                                  tags=[],
                                  language='English',
                                  dependencies='')
@@ -139,7 +141,8 @@ def test_ensure_flow_exists(self):
                                  components=collections.OrderedDict(),
                                  parameters=collections.OrderedDict(),
                                  parameters_meta_info=collections.OrderedDict(),
-                                 external_version=str(sklearn.__version__),
+                                 external_version=_format_external_version(
+                                     'sklearn', sklearn.__version__),
                                  tags=[],
                                  language='English',
                                  dependencies='')