Skip to content

Commit b91b0b8

Browse files
committed
Merge branch 'remove_dataset_pickles' of https://github.com/amueller/openml-python into amueller-remove_dataset_pickles
2 parents 2448826 + 0b05fa4 commit b91b0b8

2 files changed

Lines changed: 11 additions & 13 deletions

File tree

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,3 @@ target/
7373
# IDE
7474
.idea
7575
*.swp
76-
77-
# Other
78-
*.pkl

tests/test_datasets/test_dataset_functions.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import unittest
22
import os
3-
import shutil
3+
import os
44
import sys
55

66
if sys.version_info[0] >= 3:
@@ -22,27 +22,28 @@
2222
_get_dataset_description,
2323
_get_dataset_arff,
2424
_get_dataset_features,
25-
_get_dataset_qualities, get_dataset)
25+
_get_dataset_qualities)
2626

2727

2828
class TestOpenMLDataset(TestBase):
2929
_multiprocess_can_split_ = True
3030

3131
def setUp(self):
3232
super(TestOpenMLDataset, self).setUp()
33-
self._remove_did1()
3433

3534
def tearDown(self):
3635
super(TestOpenMLDataset, self).tearDown()
37-
self._remove_did1()
36+
self._remove_pickle_files()
3837

39-
def _remove_did1(self):
38+
def _remove_pickle_files(self):
4039
cache_dir = self.static_cache_dir
41-
did_1_dir = os.path.join(cache_dir, 'datasets', '1')
42-
try:
43-
shutil.rmtree(did_1_dir)
44-
except:
45-
pass
40+
for did in ['-1', '2']:
41+
pickle_path = os.path.join(cache_dir, 'datasets', did,
42+
'dataset.pkl')
43+
try:
44+
os.remove(pickle_path)
45+
except:
46+
pass
4647

4748
def test__list_cached_datasets(self):
4849
openml.config.set_cache_directory(self.static_cache_dir)

0 commit comments

Comments
 (0)