Skip to content

Commit 9467ed4

Browse files
mfeurerPGijsbers
authored andcommitted
Add additional part of OpenML error message to exception message (#811)
* Add additional part of OpenML error message to exception message * List installed packages in CI log * simplify exception
1 parent 5f86908 commit 9467ed4

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

ci_scripts/install.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,5 @@ fi
5353
# Install scikit-learn last to make sure the openml package installation works
5454
# from a clean environment without scikit-learn.
5555
pip install scikit-learn==$SKLEARN_VERSION
56+
57+
conda list

openml/_api_calls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,9 @@ def _parse_server_exception(response, url):
155155
# 512 for runs, 372 for datasets, 500 for flows
156156
# 482 for tasks, 542 for evaluations, 674 for setups
157157
return OpenMLServerNoResult(code, message, additional_information)
158+
full_message = '{} - {}'.format(message, additional_information)
158159
return OpenMLServerException(
159160
code=code,
160-
message=message,
161-
additional=additional_information,
161+
message=full_message,
162162
url=url
163163
)

openml/exceptions.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@ class OpenMLServerException(OpenMLServerError):
1818

1919
# Code needs to be optional to allow the exceptino to be picklable:
2020
# https://stackoverflow.com/questions/16244923/how-to-make-a-custom-exception-class-with-multiple-init-args-pickleable # noqa: E501
21-
def __init__(self, message: str, code: str = None, additional: str = None, url: str = None):
21+
def __init__(self, message: str, code: str = None, url: str = None):
2222
self.message = message
2323
self.code = code
24-
self.additional = additional
2524
self.url = url
2625
super().__init__(message)
2726

tests/test_runs/test_run_functions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ def determine_grid_size(param_grid):
420420
fold=0,
421421
)
422422
except openml.exceptions.OpenMLServerException as e:
423-
e.additional = "%s; run_id %d" % (e.additional, run.run_id)
423+
e.message = "%s; run_id %d" % (e.message, run.run_id)
424424
raise e
425425

426426
self._rerun_model_and_compare_predictions(run.run_id, model_prime,

0 commit comments

Comments
 (0)