Skip to content

Commit 69e6162

Browse files
committed
Documentation. Install scikit-learn after OpenML to make sure installation from clean works too.
1 parent 0b688e5 commit 69e6162

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

ci_scripts/install.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ popd
2626
# provided versions
2727
conda create -n testenv --yes python=$PYTHON_VERSION pip
2828
source activate testenv
29-
pip install scikit-learn==$SKLEARN_VERSION
3029

3130
python --version
3231
pip install -e '.[test]'
@@ -45,3 +44,7 @@ fi
4544
if [[ "$RUN_FLAKE8" == "true" ]]; then
4645
pip install flake8 mypy
4746
fi
47+
48+
# Install scikit-learn last to make sure the openml package installation works
49+
# from a clean environment without scikit-learn.
50+
pip install scikit-learn==$SKLEARN_VERSION

setup.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
with open("openml/__version__.py") as fh:
77
version = fh.readlines()[-1].split()[-1].strip("\"'")
88

9+
# Using Python setup.py install will try to build numpy which prone to failure and
10+
# very time consuming anyway.
911
if len(sys.argv) > 1 and sys.argv[1] == 'install':
1012
print('Please install this package with pip: `pip install -e .` '
1113
'Installation requires pip>=10.0.')

0 commit comments

Comments
 (0)