Skip to content

Commit 676b560

Browse files
committed
fix unit tests (by allowing features to be "None", as before)
1 parent bb524e7 commit 676b560

2 files changed

Lines changed: 13 additions & 11 deletions

File tree

openml/datasets/dataset.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,18 @@ def __init__(self, dataset_id=None, name=None, version=None, description=None,
7474
self.update_comment = update_comment
7575
self.md5_cheksum = md5_checksum
7676
self.data_file = data_file
77-
self.features = {}
78-
79-
for idx, xmlfeature in enumerate(features['oml:feature']):
80-
feature = OpenMLDataFeature(int(xmlfeature['oml:index']),
81-
xmlfeature['oml:name'],
82-
xmlfeature['oml:data_type'],
83-
None, #todo add nominal values (currently not in database)
84-
int(xmlfeature['oml:number_of_missing_values']))
85-
assert idx == feature.index, "Data features not provided in right order"
86-
self.features[feature.index] = feature
77+
self.features = None
78+
79+
if features is not None:
80+
self.features = {}
81+
for idx, xmlfeature in enumerate(features['oml:feature']):
82+
feature = OpenMLDataFeature(int(xmlfeature['oml:index']),
83+
xmlfeature['oml:name'],
84+
xmlfeature['oml:data_type'],
85+
None, #todo add nominal values (currently not in database)
86+
int(xmlfeature['oml:number_of_missing_values']))
87+
assert idx == feature.index, "Data features not provided in right order"
88+
self.features[feature.index] = feature
8789

8890

8991
if data_file is not None:

tests/test_datasets/test_dataset_functions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test__get_cached_dataset(self, ):
4848
features = _get_cached_dataset_features(2)
4949
self.assertIsInstance(dataset, OpenMLDataset)
5050
self.assertTrue(len(dataset.features) > 0)
51-
self.assertTrue(len(dataset.features) == len(features))
51+
self.assertTrue(len(dataset.features) == len(features['oml:feature']))
5252

5353
def test_get_chached_dataset_description(self):
5454
openml.config.set_cache_directory(self.static_cache_dir)

0 commit comments

Comments
 (0)