Skip to content

Commit 6138c52

Browse files
committed
added addtional testcases to conditional imputer
1 parent 09f6ff4 commit 6138c52

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

tests/test_utils/test_conditionalimputer.py

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,33 @@ def _do_test(self, dataset, X, nominal_indices, clf):
3434
return X_prime
3535

3636
def test_impute_indices(self):
37-
task_ids = [2,59]
37+
task_ids = [2, 24, 42, 59]
3838

3939
for task_id in task_ids:
4040
task = openml.tasks.get_task(task_id)
4141
dataset = task.get_dataset()
4242
X, _ = dataset.get_data(target=task.target_name)
4343
nominal_indices = dataset.get_features_by_type('nominal', exclude=[len(dataset.features)-1])
44-
clf = ConditionalImputer(strategy="median", strategy_nominal="most_frequent", categorical_features=nominal_indices, verbose=True)
44+
clf = ConditionalImputer(strategy="median",
45+
strategy_nominal="most_frequent",
46+
categorical_features=nominal_indices,
47+
verbose=True)
4548

4649
self._do_test(dataset, X, nominal_indices, clf)
4750

4851

4952
def test_impute_smart(self):
50-
task_ids = [2,59]
53+
task_ids = [2, 24, 42, 59]
5154

5255
for task_id in task_ids:
5356
task = openml.tasks.get_task(task_id)
5457
dataset = task.get_dataset()
5558
X, _ = dataset.get_data(target=task.target_name)
5659
nominal_indices = dataset.get_features_by_type('nominal', exclude=[len(dataset.features)-1])
57-
clf = ConditionalImputer(strategy="median", strategy_nominal="most_frequent", categorical_features=None, verbose=True)
60+
clf = ConditionalImputer(strategy="median",
61+
strategy_nominal="most_frequent",
62+
categorical_features=None,
63+
verbose=True)
5864

5965
self._do_test(dataset, X, nominal_indices, clf)
6066

@@ -66,8 +72,11 @@ def test_impute_with_constant(self):
6672
dataset = task.get_dataset()
6773
X, _ = dataset.get_data(target=task.target_name)
6874
nominal_indices = dataset.get_features_by_type('nominal', exclude=[len(dataset.features) - 1])
69-
clf = ConditionalImputer(strategy="median", strategy_nominal="most_frequent", categorical_features=None,
70-
verbose=True, empty_attribute_constant=-1)
75+
clf = ConditionalImputer(strategy="median",
76+
strategy_nominal="most_frequent",
77+
categorical_features=None,
78+
verbose=True,
79+
empty_attribute_constant=-1)
7180

7281
X_prime = self._do_test(dataset, X, nominal_indices, clf)
7382
assert np.isnan(np.min(X_prime)) == False, 'Result contains nans'

0 commit comments

Comments
 (0)