raise an error if a server call fails

Author: amueller

openml/_api_calls.py

@@ -3,6 +3,7 @@
 import arff
 
 from . import config
+from .exceptions import OpenMLServerError
 
 
 def _perform_api_call(call, data=None, file_dictionary=None,
@@ -65,6 +66,8 @@ def _read_url_files(url, data=None, file_dictionary=None, file_elements=None):
             else:
                 raise ValueError("File doesn't exist")
     response = requests.post(url, data=data, files=file_elements)
+    if response.status_code != 200:
+        raise OpenMLServerError(response.text)
     return response.status_code, response.text
 
 
@@ -74,4 +77,6 @@ def _read_url(url, data=None):
     data['api_key'] = config.apikey
 
     response = requests.post(url, data=data)
+    if response.status_code != 200:
+        raise OpenMLServerError(response.text)
     return response.status_code, response.text

openml/datasets/dataset.py

@@ -16,7 +16,6 @@
         import pickle
 
 from ..util import is_string
-from ..exceptions import OpenMLServerError
 from .._api_calls import _perform_api_call
 
 logger = logging.getLogger(__name__)
@@ -272,8 +271,6 @@ def publish(self):
                 "/data/", data=data, file_dictionary={'dataset': self.data_file})
         else:
             return_code, return_value = _perform_api_call("/data/", data=data)
-        if return_code != 200:
-            raise OpenMLServerError(return_value)
         return return_code, return_value
 
     def _to_xml(self):

openml/flows/flow.py

@@ -3,7 +3,6 @@
 import sklearn
 
 from .._api_calls import _perform_api_call
-from ..exceptions import OpenMLServerError
 
 
 class OpenMLFlow(object):
@@ -86,8 +85,6 @@ def publish(self):
         data = {'description': xml_description, 'source': self.source}
         return_code, return_value = _perform_api_call(
             "/flow/", data=data)
-        if return_code != 200:
-            raise OpenMLServerError(return_value)
         return return_code, return_value
 
     def _ensure_flow_exists(self):

openml/runs/run.py

@@ -12,7 +12,6 @@
 from ..tasks import get_task
 from ..tasks.task_functions import _create_task_from_xml
 from .._api_calls import _perform_api_call
-from ..exceptions import OpenMLServerError
 
 
 class OpenMLRun(object):
@@ -84,8 +83,6 @@ def publish(self):
                 description_xml}
         return_code, return_value = _perform_api_call(
             "/run/", file_elements=data)
-        if return_code != 200:
-            raise OpenMLServerError(return_value)
         return return_code, return_value
 
     def _create_description_xml(self):