Skip to content

Commit 523b603

Browse files
committed
Improve comments
1 parent f6b68d1 commit 523b603

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

openml/flows/flow.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,8 @@ def _add_if_nonempty(dic, key, value):
355355

356356

357357
def _check_flow(flow):
358+
# Import is not possible at the top of the file as this would cause an
359+
# ImportError due to an import cycle.
358360
import openml.flows.functions
359361

360362
flow_copy = openml.flows.functions.get_flow(flow.flow_id)

openml/flows/functions.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,6 @@ def assert_flows_equal(flow1, flow2):
144144
raise TypeError('Argument 2 must be of type OpenMLFlow, but is %s' %
145145
type(flow2))
146146

147-
# Name is actually not generated by the server, but it will be
148-
# tested further down with a getter (allows mocking in the tests)
149147
generated_by_the_server = ['flow_id', 'uploader', 'version',
150148
'upload_date', ]
151149
ignored_by_python_API = ['binary_url', 'binary_format', 'binary_md5',
@@ -170,4 +168,4 @@ def assert_flows_equal(flow1, flow2):
170168
if attr1 != attr2:
171169
raise ValueError("Flow %s: values for attribute '%s' differ: "
172170
"'%s' vs '%s'." %
173-
(str(flow1.name), str(key), str(attr1), str(attr2)))
171+
(str(flow1.name), str(key), str(attr1), str(attr2)))

0 commit comments

Comments
 (0)