Skip to content

Commit 493511a

Browse files
authored
Precommit update (#1129)
* Correctly use regex to specify files * Add type hint * Add note of fixing pre-commit hook #1129
1 parent db7bb9a commit 493511a

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

.pre-commit-config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,20 @@ repos:
99
hooks:
1010
- id: mypy
1111
name: mypy openml
12-
files: openml/*
12+
files: openml/.*
1313
- id: mypy
1414
name: mypy tests
15-
files: tests/*
15+
files: tests/.*
1616
- repo: https://gitlab.com/pycqa/flake8
1717
rev: 3.8.3
1818
hooks:
1919
- id: flake8
2020
name: flake8 openml
21-
files: openml/*
21+
files: openml/.*
2222
additional_dependencies:
2323
- flake8-print==3.1.4
2424
- id: flake8
2525
name: flake8 tests
26-
files: tests/*
26+
files: tests/.*
2727
additional_dependencies:
2828
- flake8-print==3.1.4

doc/progress.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ Changelog
88

99
0.13.0
1010
~~~~~~
11+
* FIX#1030: ``pre-commit`` hooks now no longer should issue a warning.
1112
* FIX#1110: Make arguments to ``create_study`` and ``create_suite`` that are defined as optional by the OpenML XSD actually optional.
1213
* MAIN#1088: Do CI for Windows on Github Actions instead of Appveyor.
1314

1415

16+
1517
0.12.2
1618
~~~~~~
1719

openml/study/functions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def get_nested_ids_from_result_dict(key: str, subkey: str) -> Optional[List]:
135135
) # type: BaseStudy
136136

137137
elif main_entity_type in ["tasks", "task"]:
138-
138+
tasks = cast("List[int]", tasks)
139139
study = OpenMLBenchmarkSuite(
140140
suite_id=study_id,
141141
alias=alias,

0 commit comments

Comments
 (0)