Skip to content

Commit 3e14267

Browse files
amuellermfeurer
authored andcommitted
make sure repr workes with blank / fresh datasets (#820)
* make sure repr workes with blank / fresh datasets * PEP8
1 parent b259a34 commit 3e14267

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

openml/datasets/dataset.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,12 +184,13 @@ def __repr__(self):
184184
"Download URL": self.url,
185185
"Data file": self.data_file,
186186
"Pickle file": self.data_pickle_file,
187-
"# of features": len(self.features)}
187+
"# of features": len(self.features)
188+
if self.features is not None else None}
188189
if self.upload_date is not None:
189190
fields["Upload Date"] = self.upload_date.replace('T', ' ')
190191
if self.dataset_id is not None:
191192
fields["OpenML URL"] = "{}d/{}".format(base_url, self.dataset_id)
192-
if self.qualities['NumberOfInstances'] is not None:
193+
if self.qualities is not None and self.qualities['NumberOfInstances'] is not None:
193194
fields["# of instances"] = int(self.qualities['NumberOfInstances'])
194195

195196
# determines the order in which the information will be printed

tests/test_datasets/test_dataset.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,13 @@ def setUp(self):
2828
self.jm1 = openml.datasets.get_dataset(1053, download_data=False)
2929
self.iris = openml.datasets.get_dataset(61, download_data=False)
3030

31+
def test_repr(self):
32+
# create a bare-bones dataset as would be returned by
33+
# create_dataset
34+
data = openml.datasets.OpenMLDataset(name="some name",
35+
description="a description")
36+
str(data)
37+
3138
def test_get_data_array(self):
3239
# Basic usage
3340
rval, _, categorical, attribute_names = self.dataset.get_data(dataset_format='array')

0 commit comments

Comments
 (0)