simplify global testing class, add (non)-parallel testing to OpenMLDataset

Author: mfeurer

openml/datasets/dataset.py

@@ -205,7 +205,7 @@ def get_data(self, target=None, target_dtype=int, include_row_id=False,
 
         path = self.data_pickle_file
         if not os.path.exists(path):
-            raise ValueError("Cannot find a ndarray file for dataset %s at"
+            raise ValueError("Cannot find a ndarray file for dataset %s at "
                              "location %s " % (self.name, path))
         else:
             with open(path, "rb") as fh:

openml/testing.py

@@ -19,7 +19,7 @@ class TestBase(unittest.TestCase):
     Hopefully soon allows using a test server, not the production server.
     """
 
-    def setUp(self, tmp_dir_name=None):
+    def setUp(self):
         # This cache directory is checked in to git to simulate a populated
         # cache
         self.maxDiff = None
@@ -36,8 +36,7 @@ def setUp(self, tmp_dir_name=None):
 
         self.cwd = os.getcwd()
         workdir = os.path.dirname(os.path.abspath(__file__))
-        if tmp_dir_name is None:
-            tmp_dir_name = 'tmp'
+        tmp_dir_name = self.id()
         self.workdir = os.path.join(workdir, tmp_dir_name)
         try:
             shutil.rmtree(self.workdir)

tests/test_datasets/test_dataset.py

@@ -9,6 +9,8 @@
 
 
 class OpenMLDatasetTest(unittest.TestCase):
+    # Splitting not helpful, these test's don't rely on the server and take less
+    # than 5 seconds.
 
     def setUp(self):
         # Load dataset id 1

tests/test_datasets/test_dataset_functions.py

@@ -8,7 +8,6 @@
 else:
     import mock
 
-import six
 import scipy.sparse
 
 import openml
@@ -29,10 +28,8 @@
 class TestOpenMLDataset(TestBase):
     _multiprocess_can_split_ = True
 
-    def setUp(self, tmp_dir_name=None):
-        tmp_dir_name = self.id()
-        print(tmp_dir_name)
-        super(TestOpenMLDataset, self).setUp(tmp_dir_name=tmp_dir_name)
+    def setUp(self):
+        super(TestOpenMLDataset, self).setUp()
         self._remove_did1()
 
     def tearDown(self):