added complicated testcase

Author: janvanrijn

openml/datasets/dataset.py

@@ -64,7 +64,11 @@ def __init__(self, dataset_id=None, name=None, version=None, description=None,
         self.url = url
         self.default_target_attribute = default_target_attribute
         self.row_id_attribute = row_id_attribute
-        self.ignore_attributes = list(ignore_attribute) if ignore_attribute is not None else None # TODO: check
+        self.ignore_attributes = None
+        if isinstance(ignore_attribute, str):
+            self.ignore_attributes = [ignore_attribute]
+        elif isinstance(ignore_attribute, list):
+            self.ignore_attributes = ignore_attribute
         self.version_label = version_label
         self.citation = citation
         self.tag = tag
@@ -311,6 +315,8 @@ def retrieve_class_labels(self, target_name='class'):
 
     def get_features_by_type(self, data_type, exclude=None, exclude_ignore_attributes=True):
         assert data_type in OpenMLDataFeature.LEGAL_DATA_TYPES, "Illegal feature type requested"
+        if self.ignore_attributes is not None:
+            assert type(self.ignore_attributes) is list, "ignore_attributes should be a list"
         if exclude is not None:
             assert type(exclude) is list, "Exclude should be a list"
             assert all(isinstance(elem, str) for elem in exclude), "Exclude should be a list of strings"
@@ -319,7 +325,6 @@ def get_features_by_type(self, data_type, exclude=None, exclude_ignore_attribute
             to_exclude.extend(exclude)
         if exclude_ignore_attributes and self.ignore_attributes is not None:
             to_exclude.extend(self.ignore_attributes)
-        print(to_exclude)
 
         result = []
         offset = 0

tests/test_utils/test_conditionalimputer.py

@@ -34,7 +34,7 @@ def _do_test(self, dataset, X, nominal_indices, clf):
         return X_prime
 
     def test_impute_indices(self):
-        task_ids = [2, 24, 41, 42, 59]
+        task_ids = [2, 24, 41, 42, 45, 59]
 
         for task_id in task_ids:
             task = openml.tasks.get_task(task_id)
@@ -51,7 +51,7 @@ def test_impute_indices(self):
 
 
     def test_impute_smart(self):
-        task_ids = [2, 24, 41, 42, 59]
+        task_ids = [2, 24, 41, 42, 45, 59]
 
         for task_id in task_ids:
             task = openml.tasks.get_task(task_id)