Skip to content

Commit 0453b34

Browse files
committed
Fixed the issue with the upload_dataset
You cannot create a same method with multiple parameters, therefore I have merged two methods into one. oops !! :)
1 parent 895332b commit 0453b34

2 files changed

Lines changed: 7 additions & 13 deletions

File tree

openml/apiconnector.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -934,20 +934,14 @@ def _read_url(self, url, add_authentication=False, data=None):
934934

935935
return return_code, string.getvalue()
936936

937-
def upload_dataset(self, dataset, description):
937+
def upload_dataset(self, description, dataset=None):
938938
try:
939-
data = {'dataset': dataset, 'description': description}
940-
return_code, dataset_xml = self._perform_api_call("openml.data.upload",data=data)
941-
942-
except URLError as e:
943-
# TODO logger.debug
944-
print(e)
945-
raise e
946-
return return_code, dataset_xml
939+
data={}
940+
if dataset is None:
941+
data = {'description': description}
942+
else:
943+
data = {'dataset': dataset, 'description': description}
947944

948-
def upload_dataset(self, description):
949-
try:
950-
data = {'description': description}
951945
return_code, dataset_xml = self._perform_api_call("openml.data.upload",data=data)
952946

953947
except URLError as e:

tests/test_apiconnector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ def test_upload_dataset(self):
269269
<oml:md5_checksum></oml:md5_checksum>
270270
</oml:data_set_description>
271271
"""
272-
return_code, dataset_xml = self.connector.upload_dataset(dataset, description)
272+
return_code, dataset_xml = self.connector.upload_dataset (description, dataset)
273273
self.assertEqual(return_code, 200)
274274

275275
def test_upload_dataset_features(self):

0 commit comments

Comments
 (0)