Skip to content

Commit 03f798c

Browse files
committed
readjusted max time allowed to the correct scale
1 parent 7621bff commit 03f798c

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

tests/test_runs/test_run_functions.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,14 @@ def _perform_run(self, task_id, num_instances, clf, check_setup=True):
123123
return run
124124

125125

126-
def _check_detailed_evaluations(self, detailed_evaluations, num_repeats, num_folds):
126+
def _check_detailed_evaluations(self, detailed_evaluations, num_repeats, num_folds, max_time_allowed=60000):
127127
'''
128128
Checks whether the right timing measures are attached to the run (before upload).
129129
Test is only performed for versions >= Python3.3
130130
131131
In case of check_n_jobs(clf) == false, please do not perform this check (check this
132132
condition outside of this function. )
133+
default max_time_allowed (per fold, in milli seconds) = 1 minute, quite pessimistic
133134
'''
134135
timing_measures = {'usercpu_time_millis_testing', 'usercpu_time_millis_training', 'usercpu_time_millis'}
135136

@@ -146,7 +147,7 @@ def _check_detailed_evaluations(self, detailed_evaluations, num_repeats, num_fol
146147
evaluation = detailed_evaluations[measure][rep][fold]
147148
self.assertIsInstance(evaluation, float)
148149
self.assertGreater(evaluation, 0) # should take at least one millisecond (?)
149-
self.assertLess(evaluation, 360) # 5 minutes, pessimistic
150+
self.assertLess(evaluation, max_time_allowed)
150151

151152

152153
def test_run_regression_on_classif_task(self):

0 commit comments

Comments
 (0)