Skip to content

Commit 002c420

Browse files
committed
ADD comments/warnings w.r.t. REST call compression
1 parent 26686b0 commit 002c420

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

openml/_api_calls.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import os
22
import requests
33
import arff
4+
import warnings
45

56
from . import config
67
from .exceptions import OpenMLServerError
@@ -65,9 +66,15 @@ def _read_url_files(url, data=None, file_dictionary=None, file_elements=None):
6566

6667
else:
6768
raise ValueError("File doesn't exist")
69+
70+
# Using requests.post sets header 'Accept-encoding' automatically to
71+
# 'gzip,deflate'
6872
response = requests.post(url, data=data, files=file_elements)
6973
if response.status_code != 200:
7074
raise OpenMLServerError(response.text)
75+
if 'Content-Encoding' not in response.headers or \
76+
response.headers['Content-Encoding'] != 'gzip':
77+
warnings.warn('Received uncompressed content from OpenML for %s.' % url)
7178
return response.status_code, response.text
7279

7380

@@ -76,7 +83,12 @@ def _read_url(url, data=None):
7683
data = {}
7784
data['api_key'] = config.apikey
7885

86+
# Using requests.post sets header 'Accept-encoding' automatically to
87+
# 'gzip,deflate'
7988
response = requests.post(url, data=data)
8089
if response.status_code != 200:
8190
raise OpenMLServerError(response.text)
91+
if 'Content-Encoding' not in response.headers or \
92+
response.headers['Content-Encoding'] != 'gzip':
93+
warnings.warn('Received uncompressed content from OpenML for %s.' % url)
8294
return response.status_code, response.text

0 commit comments

Comments
 (0)