Skip to content

Commit 19045c8

Browse files
committed
cron only run for installed modules
1 parent bafd3d3 commit 19045c8

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

tools/cli/commands/cron.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
$lock = new \OBFLock('core-cron');
1515

1616
// require cron files
17-
// TODO add support for module cron classes (last run tracked in db as cron-modulename-classname).
1817
$jobs = [];
1918
require_once('classes/base/cron.php');
2019
foreach (glob('classes/cron/*.php') as $file) {
@@ -24,6 +23,15 @@
2423
}
2524

2625
foreach (glob('modules/*', GLOB_ONLYDIR) as $module) {
26+
// Only run cron jobs for installed modules.
27+
$moduleDir = basename($module);
28+
$db->where('directory', $moduleDir);
29+
$moduleInstalled = $db->get_one('modules');
30+
if (!$moduleInstalled) {
31+
continue;
32+
}
33+
34+
// Require module cron files and add to jobs array.
2735
foreach (glob($module . '/cron/*.php') as $file) {
2836
$moduleNamespace = str_replace(' ', '', ucwords(str_replace('_', ' ', basename($module))));
2937
require_once($file);

0 commit comments

Comments
 (0)