Don't treat GPS communication as failed if we receive a NACK

amandel · amandel · commit e8a395e2d1ea · 2022-05-07T12:41:42.000+02:00
Even if the message is denied we are actually communicating ;) this caused likely #309
diff --git a/src/gps.cpp b/src/gps.cpp
@@ -313,7 +313,7 @@ bool Gps::setBaud() {
 /* Send a "ping" message to the gps module and check,
  * if we get a response. */
 bool Gps::checkCommunication() {
-  return sendAndWaitForAck(UBX_MSG::CFG_RINV);
+  return sendAndWaitForAck(UBX_MSG::CFG_RINV) || mAckReceived || mNakReceived;
 }
 
 bool Gps::sendAndWaitForAck(UBX_MSG ubxMsgId, const uint8_t *buffer, size_t size) {

Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,7 @@ bool Gps::setBaud() {`
`313`	`313`	`/* Send a "ping" message to the gps module and check,`
`314`	`314`	`* if we get a response. */`
`315`	`315`	`bool Gps::checkCommunication() {`
`316`		`- return sendAndWaitForAck(UBX_MSG::CFG_RINV);`
	`316`	`+ return sendAndWaitForAck(UBX_MSG::CFG_RINV) \|\| mAckReceived \|\| mNakReceived;`
`317`	`317`	`}`
`318`	`318`
`319`	`319`	`bool Gps::sendAndWaitForAck(UBX_MSG ubxMsgId, const uint8_t *buffer, size_t size) {`