remove unused method

add additional specs

Author: kkoehn

app/models/code_ocean/file.rb

@@ -91,11 +91,6 @@ def teacher_defined_assessment?
       teacher_defined_test? || teacher_defined_linter?
     end
 
-    def content_present?
-      content? || attachment.attached?
-    end
-    private :content_present?
-
     def filepath
       if path.present?
         ::File.join(path, name_with_extension)

spec/controllers/code_ocean/files_controller_spec.rb

@@ -81,4 +81,37 @@
       expect { perform_request.call }.to change(CodeOcean::File, :count).by(-1)
     end
   end
+
+  describe 'GET #render_protected_upload' do
+    let(:exercise) { create(:audio_video) }
+    let(:submission) { create(:submission, exercise:, contributor: create(:external_user)) }
+    let(:file) { exercise.files.detect {|f| f.file_type.file_extension == '.mp4' } }
+    let(:token) { Rack::Utils.parse_nested_query(URI.parse(signed_url).query)['token'] }
+
+    context 'with a valid signed URL and matching filename' do
+      let(:signed_url) { AuthenticatedUrlHelper.sign(render_protected_upload_url(id: file, filename: file.filepath), file) }
+
+      before do
+        get :render_protected_upload, params: {id: file.id, filename: file.filepath, token:}
+      end
+
+      expect_assigns(file: :file)
+      expect_redirect
+
+      it 'redirects to ActiveStorage blob with inline disposition' do
+        location = response.headers['Location'] || response.location
+        expect(location).to include('disposition=inline')
+        expect(location).to include(file.attachment.filename.to_s)
+      end
+    end
+
+    context 'with a mismatching filename' do
+      let(:signed_url) { AuthenticatedUrlHelper.sign(render_protected_upload_url(id: file, filename: file.filepath), file) }
+
+      it 'returns unauthorized' do
+        get :render_protected_upload, params: {id: file.id, filename: 'wrong/name.mp4', token:}
+        expect(response).to have_http_status(:unauthorized)
+      end
+    end
+  end
 end

spec/models/code_ocean/file_spec.rb

@@ -108,4 +108,21 @@
       end
     end
   end
+
+  describe '#size' do
+    subject { file.size }
+
+    let(:content) { 'file content' }
+    let(:file) { create(:file, :image, content:) }
+
+    after { file.attachment.purge }
+
+    it { is_expected.to be file.attachment.byte_size }
+
+    context 'when the file is not attached' do
+      before { file.attachment.purge }
+
+      it { is_expected.to be content.length }
+    end
+  end
 end