Switch to Rspec native transactional fixtures to replace database cleaner

With the previous change to system specs and the new framework defaults, we can drop the database cleaner entirely. All tests will only be executed as part of a transaction, and nothing is stored in the database.

Author: MrSerth

Gemfile

@@ -85,7 +85,6 @@ end
 
 group :test do
   gem 'capybara'
-  gem 'database_cleaner'
   gem 'factory_bot_rails'
   gem 'pundit-matchers'
   gem 'rails-controller-testing'

Gemfile.lock

@@ -136,12 +136,6 @@ GEM
     csv (3.3.0)
     dachsfisch (1.0.0)
       nokogiri (>= 1.14.1, < 2.0.0)
-    database_cleaner (2.0.2)
-      database_cleaner-active_record (>= 2, < 3)
-    database_cleaner-active_record (2.2.0)
-      activerecord (>= 5.a)
-      database_cleaner-core (~> 2.0.0)
-    database_cleaner-core (2.0.1)
     date (3.3.4)
     debug_inspector (1.2.0)
     deep_merge (1.2.2)
@@ -610,7 +604,6 @@ DEPENDENCIES
   capybara
   coffee-rails
   config
-  database_cleaner
   devise (~> 4.9)
   devise-bootstrap-views
   factory_bot_rails

spec/db/seeds_spec.rb

@@ -14,16 +14,14 @@
     Rake::Task['db:migrate'].invoke
 
     # We want to execute the seeds for the dev environment against the test database
-    # rubocop:disable Rails/Inquiry
-    allow(Rails).to receive(:env) { 'development'.inquiry }
-    # rubocop:enable Rails/Inquiry
+    allow(Rails).to receive(:env) { 'development'.inquiry } # rubocop:disable Rails/Inquiry
     allow(ActiveRecord::Base).to receive(:establish_connection).and_call_original
     allow(ActiveRecord::Base).to receive(:establish_connection).with(:development) {
       ActiveRecord::Base.establish_connection(:test)
     }
   end
 
-  describe 'execute db:seed', cleaning_strategy: :truncation do
+  describe 'execute db:seed' do
     it 'collects the test results' do
       expect { seed }.not_to raise_error
     end

spec/rails_helper.rb

@@ -42,7 +42,7 @@
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
   # instead of true.
-  config.use_transactional_fixtures = false
+  config.use_transactional_fixtures = true
 
   # You can uncomment this line to turn off ActiveRecord support entirely.
   # config.use_active_record = false