test: napi v4,v5 all tests pass

Author: KevinEady

napi-inl.h

@@ -4551,7 +4551,7 @@ ThreadSafeFunctionEx<ContextType, DataType, CallJs>::New(
   return tsfn;
 }
 
-// static, with Callback [x] Resource [x] Finalizer [missing]
+// static, with Callback [passed] Resource [passed] Finalizer [missing]
 template <typename ContextType, typename DataType,
           void (*CallJs)(Napi::Env, Napi::Function, ContextType *, DataType *)>
 template <typename ResourceString>
@@ -4574,7 +4574,7 @@ ThreadSafeFunctionEx<ContextType, DataType, CallJs>::New(
   return tsfn;
 }
 
-// static, with Callback [x] Resource [missing ] Finalizer [x]
+// static, with Callback [passed] Resource [missing] Finalizer [passed]
 template <typename ContextType, typename DataType,
           void (*CallJs)(Napi::Env, Napi::Function, ContextType *, DataType *)>
 template <typename ResourceString, typename Finalizer,
@@ -4604,7 +4604,7 @@ ThreadSafeFunctionEx<ContextType, DataType, CallJs>::New(
   return tsfn;
 }
 
-// static, with: Callback [x] Resource [x] Finalizer [x]
+// static, with: Callback [passed] Resource [passed] Finalizer [passed]
 template <typename ContextType, typename DataType,
           void (*CallJs)(Napi::Env, Napi::Function, ContextType *, DataType *)>
 template <typename ResourceString, typename Finalizer,

napi.h

@@ -2043,7 +2043,9 @@ namespace Napi {
   };
 
   #if (NAPI_VERSION > 3)
-  template <typename ContextType = void, typename DataType = void,
+  // A ThreadSafeFunctionEx by default has no context (nullptr) and can accept
+  // any type (void) to its CallJs.
+  template <typename ContextType = std::nullptr_t, typename DataType = void,
             void (*CallJs)(Napi::Env, Napi::Function, ContextType *,
                            DataType *) = nullptr>
   class ThreadSafeFunctionEx {
@@ -2058,7 +2060,8 @@ namespace Napi {
     // This API may only be called from the main thread.
     // Helper function that returns nullptr if running N-API 5+, otherwise a
     // non-empty, no-op Function. This provides the ability to specify at
-    // compile-time a callback parameter to `New` that safely does no action.
+    // compile-time a callback parameter to `New` that safely does no action
+    // when targeting _any_ N-API version.
     static DefaultFunctionType DefaultFunctionFactory(Napi::Env env);
 
 #if NAPI_VERSION > 4

test/threadsafe_function_ex/index.js

@@ -1,5 +1,13 @@
+const tests = [
+    // 'threadsafe', 
+    'basic', 
+    'example'
+];
+
+// Threadsafe tests must run synchronously. If two threaded-tests are running
+// and one fails, Node may exit while `std::thread`s are running.
 module.exports = (async () => {
-    await require('./test/threadsafe')
-    await require('./test/basic');
-    await require('./test/example');
-})();
+    for (const test of tests) {
+        await require(`./test/${test}`);
+    }
+})();