chore(ci): Fixing clippy warnings and add clippy to CI

Added clippy to CI pipeline.

Various clippy issues fixed, among others:

- Explicit truncate behavior
- zero bytes without loop variable
- renamed modules to not have the same name as their parent modules
- use or_default instead of or_insert_with
- merged if statements in string_length module
- allowing large enum variant for some parser types

Additional fix: removed some variants of the `and_opt` parser.

Author: ngeor

.github/workflows/build.yml

@@ -17,6 +17,8 @@ jobs:
         run: cargo build
       - name: Test
         run: cargo test
+      - name: Clippy
+        run: cargo clippy -- -Dwarnings
   build-release:
     runs-on: ubuntu-latest
     steps:
@@ -43,6 +45,8 @@ jobs:
         run: cargo build
       - name: Test
         run: cargo test
+      - name: Clippy
+        run: cargo clippy -- -Dwarnings
   build-windows-release:
     runs-on: windows-latest
     steps:

…ction_generator/instruction_generator.rs …_basic/src/instruction_generator/main.rsrusty_basic/src/instruction_generator/instruction_generator.rs renamed to rusty_basic/src/instruction_generator/main.rs rusty_basic/src/instruction_generator/instruction_generator.rs renamed to rusty_basic/src/instruction_generator/main.rs

@@ -2,9 +2,9 @@ mod calls;
 mod dim;
 mod expression;
 mod if_block;
-mod instruction_generator;
 mod label_resolver;
 mod loops;
+mod main;
 pub mod print;
 mod select_case;
 mod statement;
@@ -15,4 +15,4 @@ pub mod test_utils;
 #[cfg(test)]
 mod tests;
 
-pub use self::instruction_generator::*;
+pub use self::main::*;

rusty_basic/src/instruction_generator/mod.rs

@@ -25,6 +25,7 @@ impl QByteSize for Variant {
 
 impl QByteSize for VArray {
     fn byte_size(&self) -> usize {
+        // TODO: this breaks for String arrays because Strings have variable length (and what if the first element is empty)
         self.len() * self.first().byte_size()
     }
 }

rusty_basic/src/interpreter/byte_size.rs

@@ -94,11 +94,9 @@ impl FileInfo {
         file.seek(SeekFrom::Start(offset))?;
         let mut buffer: Vec<u8> = std::iter::repeat_n(0_u8, self.rec_len).collect();
         let bytes_read = file.read(&mut buffer)?;
-        if bytes_read < buffer.len() {
-            // zero out missing bytes
-            for i in bytes_read..buffer.len() {
-                buffer[i] = 0;
-            }
+        // zero out missing bytes
+        for item in buffer.iter_mut().skip(bytes_read) {
+            *item = 0;
         }
         Ok(buffer)
     }
@@ -162,6 +160,7 @@ impl FileManager {
                     .read(true)
                     .write(true)
                     .create(true)
+                    .truncate(true)
                     .open(file_name)?;
                 self.handle_map
                     .insert(handle, FileInfo::new_random(file, rec_len));

rusty_basic/src/interpreter/io.rs

@@ -7,11 +7,11 @@ mod default_stdlib;
 pub mod error;
 mod handlers;
 mod indexed_map;
-mod interpreter;
 mod interpreter_trait;
 mod io;
 mod keyboard;
 mod lpt1_write;
+mod main;
 mod print;
 mod read_input;
 mod registers;
@@ -27,8 +27,8 @@ mod test_utils;
 #[cfg(test)]
 mod tests;
 
-pub use self::interpreter::new_default_interpreter;
 pub use self::interpreter_trait::InterpreterTrait;
+pub use self::main::new_default_interpreter;
 pub use self::stdlib::*;
 
 fn is_cr_lf(ch: char) -> bool {

…sty_basic/src/interpreter/interpreter.rs rusty_basic/src/interpreter/main.rsrusty_basic/src/interpreter/interpreter.rs renamed to rusty_basic/src/interpreter/main.rs rusty_basic/src/interpreter/interpreter.rs renamed to rusty_basic/src/interpreter/main.rs

@@ -11,8 +11,8 @@ use crate::instruction_generator::{
     InstructionGeneratorResult, generate_instructions, unwrap_linter_context
 };
 use crate::interpreter::Stdlib;
-use crate::interpreter::interpreter::Interpreter;
 use crate::interpreter::interpreter_trait::InterpreterTrait;
+use crate::interpreter::main::Interpreter;
 use crate::interpreter::read_input::ReadInputSource;
 use crate::interpreter::screen::{CrossTermScreen, HeadlessScreen};
 use crate::interpreter::write_printer::WritePrinter;

rusty_basic/src/interpreter/mod.rs

@@ -11,7 +11,7 @@ pub fn lint(args: &Expressions, pos: Position) -> Result<(), LintErrorPos> {
     if args.len() < 4 {
         return Err(LintError::ArgumentCountMismatch.at_pos(pos));
     }
-    if (args.len() - 1) % 3 != 0 {
+    if !(args.len() - 1).is_multiple_of(3) {
         return Err(LintError::ArgumentCountMismatch.at_pos(pos));
     }
     args.require_integer_argument(0)?;

rusty_basic/src/interpreter/test_utils.rs

@@ -13,7 +13,7 @@ pub fn lint(args: &Expressions, pos: Position) -> Result<(), LintErrorPos> {
     let Positioned {
         element: first,
         pos: first_pos,
-    } = args.get(0).unwrap();
+    } = args.first().unwrap();
     if let Expression::Variable(
         _,
         VariableInfo {