FileUpload: file_info can return false [Closes #145]

dg · dg · commit f259baffb69b · 2018-08-27T19:59:55.000+02:00
diff --git a/src/Http/FileUpload.php b/src/Http/FileUpload.php
@@ -31,7 +31,7 @@ final class FileUpload
 	/** @var string */
 	private $name;
 
-	/** @var string */
+	/** @var string|null|false */
 	private $type;
 
 	/** @var int */
@@ -85,7 +85,7 @@ public function getContentType(): ?string
 		if ($this->isOk() && $this->type === null) {
 			$this->type = finfo_file(finfo_open(FILEINFO_MIME_TYPE), $this->tmpName);
 		}
-		return $this->type;
+		return $this->type ?: null;
 	}
 
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ final class FileUpload`
`31`	`31`	`/** @var string */`
`32`	`32`	`private $name;`
`33`	`33`
`34`		`- /** @var string */`
	`34`	`+ /** @var string\|null\|false */`
`35`	`35`	`private $type;`
`36`	`36`
`37`	`37`	`/** @var int */`
`@@ -85,7 +85,7 @@ public function getContentType(): ?string`
`85`	`85`	`if ($this->isOk() && $this->type === null) {`
`86`	`86`	`$this->type = finfo_file(finfo_open(FILEINFO_MIME_TYPE), $this->tmpName);`
`87`	`87`	`}`
`88`		`- return $this->type;`
	`88`	`+ return $this->type ?: null;`
`89`	`89`	`}`
`90`	`90`
`91`	`91`