Selection: Fixed accidental deletion of referenced cached rows when emptyResultSet is called (#187)(#207)

MartinMystikJonas · dg · commit 37cc8baaa0a2 · 2018-10-01T10:37:35.000+02:00
diff --git a/src/Database/Table/Selection.php b/src/Database/Table/Selection.php
@@ -596,7 +596,8 @@ protected function emptyResultSet(bool $clearCache = true, bool $deleteRererence
 			$this->cache->setGeneralCacheKey(null);
 		}
 
-		$this->rows = null;
+		$null = null;
+		$this->rows = &$null;
 		$this->cache->setSpecificCacheKey(null);
 		$this->refCache->clearReferencingPrototype();
 		if ($deleteRererencedCache) {

Original file line number	Diff line number	Diff line change
`@@ -596,7 +596,8 @@ protected function emptyResultSet(bool $clearCache = true, bool $deleteRererence`
`596`	`596`	`$this->cache->setGeneralCacheKey(null);`
`597`	`597`	`}`
`598`	`598`
`599`		`- $this->rows = null;`
	`599`	`+ $null = null;`
	`600`	`+ $this->rows = &$null;`
`600`	`601`	`$this->cache->setSpecificCacheKey(null);`
`601`	`602`	`$this->refCache->clearReferencingPrototype();`
`602`	`603`	`if ($deleteRererencedCache) {`