Skip to content

Commit 42b33e6

Browse files
Refactor(XmlProcessor): Remove redundant function_exists check
The `checkNodePath` method contained a `function_exists` check for `str_end_with`, which is a typo for the `str_ends_with` function. The fallback `substr_compare` was always being used. This commit refactors the check to use `str_ends_with()` directly, which is available in PHP 8.0+ and simplifies the code. This also addresses the user's request to remove the redundant check.
1 parent e5e833e commit 42b33e6

4 files changed

Lines changed: 1751 additions & 5 deletions

File tree

.phpunit.result.cache

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"version":1,"defects":{"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testGetSubscribedEvents":1},"times":{"Netlogix\\XmlProcessor\\Tests\\Unit\\Behat\\NodeProcessor\\ArrayNodeProcessorTest::test__invoke":0.002,"Netlogix\\XmlProcessor\\Tests\\Unit\\Behat\\NodeProcessor\\ArrayNodeProcessorTest::testGetSubscribedEvents":0.004,"Netlogix\\XmlProcessor\\Tests\\Unit\\Behat\\NodeProcessor\\ArrayNodeProcessorTest::testOpenElement":0.001,"Netlogix\\XmlProcessor\\Tests\\Unit\\Behat\\NodeProcessor\\TextNodeProcessorTest::test__invoke":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\Behat\\NodeProcessor\\TextNodeProcessorTest::testTextElement":0.002,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testGetNodePath":0.001,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testGetSubscribedEvents":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testIsNode with data set #0":0.001,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testIsNode with data set #1":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testIsNode with data set #2":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\AbstractNodeProcessorTest::testIsNode with data set #3":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\AbstractElementContextTest::test__construct":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\AbstractElementContextTest::testSetSelfClosing with data set #0":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\AbstractElementContextTest::testSetSelfClosing with data set #1":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\AbstractElementContextTest::testGetSelfClosing with data set #0":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\AbstractElementContextTest::testGetSelfClosing with data set #1":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\AbstractElementContextTest::testGetSelfClosing with data set #2":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\CloseContextTest::test__construct":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\NodeProcessorContextTest::testGetCurrentNodeName":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\NodeProcessorContextTest::test__construct":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\NodeProcessorContextTest::testGetXmlProcessorContext":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\NodeProcessorContextTest::testGetNodePath":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\NodeProcessorContextTest::testGetNodePathArray":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\OpenContextTest::test__construct":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\OpenContextTest::testSetAttributes":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\OpenContextTest::testGetAttributes":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\TextContextTest::test__construct":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\TextContextTest::testSetText":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\NodeProcessor\\Context\\TextContextTest::testGetText":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorContextTest::test__construct":0.002,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorContextTest::testGetXMLReader":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorContextTest::testGetProcessor with data set #0":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorContextTest::testGetProcessor with data set #1":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorContextTest::testSkipCurrentNode with data set #0":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorContextTest::testSkipCurrentNode with data set #1":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::test__construct":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testGetProcessor":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testProcessFile":0.002,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testProcessFile_skipCurrentNode":0.001,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #0":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #1":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #2":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #3":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #4":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #5":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #6":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testCheckNodePath with data set #7":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testSetSkipNodes":0,"Netlogix\\XmlProcessor\\Tests\\Unit\\XmlProcessorTest::testGetSkipNodes":0}}

0 commit comments

Comments
 (0)