Merge pull request #40 from netlogix/fix/properly-clone-argument

stephanschuler · web-flow · commit b668a972c925 · 2024-02-23T15:34:05.000+01:00
fix: Properly clone request arguments
diff --git a/Classes/Controller/GenericModelController.php b/Classes/Controller/GenericModelController.php
@@ -369,8 +369,9 @@ protected function remapActionArgument(string $argumentName, string $modelClassN
             $argumentTemplate->getName(),
             $modelClassName
         );
+        assert($newArgument instanceof Argument);
 
-        $this->arguments[$argumentName] = $newArgument;
+        $this->arguments[$argumentName] = $this->cloneActionArgument($argumentTemplate, $newArgument);
     }
 
     protected function cloneActionArgument($argumentTemplate, Argument $newArgument)

Original file line number	Diff line number	Diff line change
`@@ -369,8 +369,9 @@ protected function remapActionArgument(string $argumentName, string $modelClassN`
`369`	`369`	`$argumentTemplate->getName(),`
`370`	`370`	`$modelClassName`
`371`	`371`	`);`
	`372`	`+ assert($newArgument instanceof Argument);`
`372`	`373`
`373`		`- $this->arguments[$argumentName] = $newArgument;`
	`374`	`+ $this->arguments[$argumentName] = $this->cloneActionArgument($argumentTemplate, $newArgument);`
`374`	`375`	`}`
`375`	`376`
`376`	`377`	`protected function cloneActionArgument($argumentTemplate, Argument $newArgument)`