Skip to content

WIP: set default geometry value#139

Open
cielavenir wants to merge 16 commits into
masterfrom
setDefaultGeometryValue
Open

WIP: set default geometry value#139
cielavenir wants to merge 16 commits into
masterfrom
setDefaultGeometryValue

Conversation

@cielavenir

@cielavenir cielavenir commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

I found that webstack geometry API does not return "visible" field always, which has to be interpreted as true.

As C++ does not have None value, the value is undefined. I saw something like 106 or 112, random.

This is the cause of test_planningsystem test_ObjectVisible flakiness.

@woswos @lazydroid There might be some other fields which might need to be filled as well, could you check?

/cc @felixvd @ntohge

@cielavenir

Copy link
Copy Markdown
Contributor Author

@woswos @ziyan test_ObjectVisible firstly failed in pipelineid=379165 (Pipeline #601478). Do you know some background?

@cielavenir

Copy link
Copy Markdown
Contributor Author

Would need to ask for review from Yoshiki

@cielavenir cielavenir requested a review from felixvd December 8, 2023 02:23
@cielavenir

Copy link
Copy Markdown
Contributor Author

I want to improve this MR when I have time, but testing is tiresome, so I'm going to ensure building by #146 .

@cielavenir cielavenir requested a review from hemangandhi April 15, 2024 03:11

@hemangandhi hemangandhi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread src/CMakeLists.txt Outdated
Comment thread src/mujincontrollerclient.cpp Outdated
@cielavenir

Copy link
Copy Markdown
Contributor Author

@felixvd @hemangandhi could you check if there are missing header initialization than visible?

@cielavenir

Copy link
Copy Markdown
Contributor Author

it is almost 1 year.

now it is in hurry.

I filed document/team#193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants