Skip to content

Commit a1b7b24

Browse files
committed
add remaster query
1 parent 6f008fe commit a1b7b24

1 file changed

Lines changed: 13 additions & 21 deletions

File tree

pythonbits/bb.py

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -861,37 +861,24 @@ class MusicSubmission(AudioSubmission):
861861
default_fields = (AudioSubmission.default_fields + (
862862
'remaster', 'remaster_year', 'remaster_title'))
863863
_form_type = 'Music'
864-
# # submit
865-
# # type
866-
# # artist
867-
# # title
868-
# remaster_true (checkbox, special edition info) (!?!?!)
869-
# -> remaster_year
870-
# -> remaster_title (optional)
871-
# # year
872-
# # scene (checkbox)
873-
# # format (select, options: MP3, FLAC, Ogg, AAC, DTS 5.1 Audio,
874-
# 24bit FLAC)
875-
# # bitrate (select, options: 192, V2 (VBR), 256, V0 (VBR), 320, Lossless,
876-
# Other)
877-
# # media (select, options: CD, DVD, Vinyl, Soundboard, DAT, Web)
878-
# # image
879-
# album_desc (!!!)
880-
# # release_desc (optional)
881864

882865
@form_field('remaster_true', 'checkbox')
883866
def _render_remaster(self):
884867
# todo user input function/module to reduce boilerplating
885868
return bool(
886-
input('Is this a special/remastered edition?').lower() != 'n')
869+
input('Is this a special/remastered edition? [y/N] ').lower()
870+
!= 'n')
887871

888872
@form_field('remaster_year')
889873
def _render_remaster_year(self):
890-
pass
874+
if self['remaster']:
875+
return input('Please enter the remaster year: ')
891876

892877
@form_field('remaster_title')
893878
def _render_remaster_title(self):
894-
pass
879+
if self['remaster']:
880+
return (input('Please enter the remaster title (optional): ')
881+
or None)
895882

896883
@form_field('format')
897884
def _render_format(self):
@@ -941,6 +928,8 @@ def _render_bitrate(self):
941928

942929
@form_field('media')
943930
def _render_media(self):
931+
choices = ['CD', 'DVD', 'Vinyl', 'Soundboard', 'DAT', 'Web']
932+
944933
media = self['summary']['media']
945934
if len(media) > 1:
946935
log.debug(media)
@@ -1040,7 +1029,10 @@ def _render_release(self):
10401029
# - scan for mb tags
10411030
print('rg', rg)
10421031
print('r', release)
1043-
# todo: assert # of tracks equal
1032+
1033+
# todo: assert release group matches!
1034+
# e.g.: assert # of tracks equal
1035+
# and if not, generate basic info from release group only
10441036

10451037
return release, rg
10461038

0 commit comments

Comments
 (0)