Skip to content

Commit 8fc69e4

Browse files
committed
fix musicbrainz search bug due to retval order
1 parent f2ce6f2 commit 8fc69e4

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

pythonbits/bb.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ def subcategory(self):
8484
log.info("Unable to guess submission category using known mimetypes")
8585
while True:
8686
cat = input("Please manually specify category. "
87-
"\nOptions: {}\nCategory: ".format(
88-
", ".join(cat_map.keys())))
87+
"\nOptions: {}"
88+
"\nCategory: ".format(", ".join(cat_map.keys())))
8989
try:
9090
return cat_map[cat]
9191
except KeyError:
@@ -1037,7 +1037,7 @@ def _render_release(self):
10371037
else:
10381038
query_artist = tags['artist']
10391039
query = tags['title']
1040-
rg, release = mb.find_release(query, artist=query_artist)
1040+
release, rg = mb.find_release(query, artist=query_artist)
10411041

10421042
# identify self:
10431043
# - num tracks todo

pythonbits/musicbrainz.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ def find_release_group(release_title, artist=None):
4545
except IndexError:
4646
pass
4747
else:
48-
return choice
48+
return musicbrainzngs.get_release_group_by_id(
49+
choice['id'],
50+
includes=['tags', 'artist-credits', 'url-rels']
51+
)['release-group']
4952

5053

5154
def find_release(release_title, artist=None):
@@ -76,8 +79,9 @@ def find_release(release_title, artist=None):
7679
choice = results[int(choice)]
7780
except (IndexError, ValueError):
7881
if choice == '':
79-
return release_group, None
82+
return None, release_group
8083
else:
8184
release = musicbrainzngs.get_release_by_id(
82-
choice['id'], includes=['media', 'recordings'])['release']
83-
return release_group, release
85+
choice['id'], includes=['release-groups', 'media',
86+
'recordings', 'url-rels'])['release']
87+
return release, release_group

0 commit comments

Comments
 (0)