Skip to content

Commit 449342c

Browse files
committed
MQTT: Only warn about ack/nack if debug is enabled
1 parent 41d771d commit 449342c

1 file changed

Lines changed: 14 additions & 5 deletions

File tree

src/msgflo.cpp

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,18 +243,27 @@ using msg_flo_mqtt_client = mqtt_client<trygvis::mqtt_support::mqtt_client_perso
243243
class MosquittoEngine final : public Engine, protected mqtt_event_listener, protected AbstractEngine<MosquittoEngine> {
244244

245245
struct MosquittoMessage final : public AbstractMessage {
246-
MosquittoMessage(const struct mosquitto_message *m)
247-
: AbstractMessage(static_cast<char *>(m->payload), static_cast<uint64_t>(m->payloadlen)), _mid(m->mid) {
246+
MosquittoMessage(const struct mosquitto_message *m, bool d)
247+
: AbstractMessage(static_cast<char *>(m->payload), static_cast<uint64_t>(m->payloadlen))
248+
, _mid(m->mid)
249+
, _debugOutput(d)
250+
{
251+
248252
}
249253

250254
int _mid;
255+
bool _debugOutput = false;
251256

252257
virtual void ack() override {
253-
cerr << "MosquittoMessage.ack() is not implemented" << endl;
258+
if (_debugOutput) {
259+
cerr << "MosquittoMessage.ack() is currently a no-op" << endl;
260+
}
254261
}
255262

256263
virtual void nack() override {
257-
cerr << "MosquittoMessage.nack() is not implemented" << endl;
264+
if (_debugOutput) {
265+
cerr << "MosquittoMessage.nack() is currently a no-op" << endl;
266+
}
258267
}
259268
};
260269

@@ -310,7 +319,7 @@ class MosquittoEngine final : public Engine, protected mqtt_event_listener, prot
310319
for (auto &r : registrations) {
311320
for (auto &p : r.inports) {
312321
if (p.queue == topic) {
313-
MosquittoMessage m(message);
322+
MosquittoMessage m(message, _debugOutput);
314323

315324
r.handler(&m);
316325
}

0 commit comments

Comments
 (0)