Skip to content

Commit d1b783c

Browse files
mpywclaude
andcommitted
fix: simplify Codecov flag configuration and fix lint errors
- Remove paths filter from individual_flags (Go coverage uses full module paths like github.com/mpyw/sql-http-proxy/internal/...) - Simplify CI flags from unit,go1.23 to just unit (avoid multi-flag complexity) - Add verbose: true to codecov-action for debugging - Fix errcheck and ineffassign lint errors in headers_test.go Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 77182be commit d1b783c

4 files changed

Lines changed: 10 additions & 15 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,16 @@ jobs:
3636
with:
3737
token: ${{ secrets.CODECOV_TOKEN }}
3838
files: ./coverage-unit.txt
39-
flags: unit,go${{ matrix.go-version }}
39+
flags: unit
40+
verbose: true
4041

4142
- name: Upload e2e test coverage to Codecov
4243
uses: codecov/codecov-action@v5
4344
with:
4445
token: ${{ secrets.CODECOV_TOKEN }}
4546
files: ./coverage-e2e.txt
46-
flags: e2e,go${{ matrix.go-version }}
47+
flags: e2e
48+
verbose: true
4749

4850
lint:
4951
name: Lint

codecov.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,8 @@ flag_management:
1414
carryforward: true
1515
individual_flags:
1616
- name: unit
17-
paths:
18-
- internal/
1917
carryforward: true
2018
- name: e2e
21-
paths:
22-
- internal/
2319
carryforward: true
2420

2521
comment:

internal/js/headers_test.go

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,9 @@ func TestHeaders_ToJSObject(t *testing.T) {
204204
require.NotNil(t, obj)
205205

206206
t.Run("get method", func(t *testing.T) {
207-
result, err := vm.RunString(`
208-
var headers = this.headers;
209-
headers.get("Content-Type");
210-
`)
211-
_ = vm.Set("headers", obj)
212-
result, err = vm.RunString(`headers.get("Content-Type")`)
207+
err := vm.Set("headers", obj)
208+
require.NoError(t, err)
209+
result, err := vm.RunString(`headers.get("Content-Type")`)
213210
require.NoError(t, err)
214211
assert.Equal(t, "application/json", result.String())
215212
})
@@ -265,8 +262,9 @@ func TestHeaders_ToJSObject(t *testing.T) {
265262
})
266263

267264
t.Run("forEach method", func(t *testing.T) {
268-
vm.Set("callCount", 0)
269-
_, err := vm.RunString(`
265+
err := vm.Set("callCount", 0)
266+
require.NoError(t, err)
267+
_, err = vm.RunString(`
270268
headers.forEach(function(value, key) {
271269
callCount++;
272270
})

internal/server/server.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,4 +118,3 @@ func expandPathShorthands(path string) string {
118118
}
119119
return result.String()
120120
}
121-

0 commit comments

Comments
 (0)