Skip to content

Commit 2796502

Browse files
committed
Change to emit warnings when verifying with private keys
1 parent 5eb382e commit 2796502

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

jose/backends/pycrypto_backend.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from base64 import b64encode
22

33
import six
4+
import warnings
45

56
import Crypto.Hash.SHA256
67
import Crypto.Hash.SHA384
@@ -148,7 +149,8 @@ def sign(self, msg):
148149

149150
def verify(self, msg, sig):
150151
if not self.is_public():
151-
return False
152+
warnings.warn("Attempting to verify a message with a private key. "
153+
"This is not recommended.")
152154
try:
153155
return PKCS1_v1_5.new(self.prepared_key).verify(self.hash_alg.new(msg), sig)
154156
except Exception:

jose/backends/rsa_backend.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import binascii
22

33
import six
4+
import warnings
5+
46
from pyasn1.error import PyAsn1Error
57

68
import rsa as pyrsa
@@ -201,7 +203,8 @@ def sign(self, msg):
201203

202204
def verify(self, msg, sig):
203205
if not self.is_public():
204-
return False
206+
warnings.warn("Attempting to verify a message with a private key. "
207+
"This is not recommended.")
205208
try:
206209
pyrsa.verify(msg, sig, self._prepared_key)
207210
return True

0 commit comments

Comments
 (0)