Skip to content

Commit 3584702

Browse files
committed
Rename exception type
Thanks @leplatrem for the suggestion.
1 parent 3e1b47c commit 3584702

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

autograph_utils/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def detail(self):
169169
)
170170

171171

172-
class CertificateUnknownPublicKey(BadCertificate):
172+
class CertificateUnsupportedKeyType(BadCertificate):
173173
"""An internal error indicating that support for some type of key is missing."""
174174

175175
def __init__(self, cert, key):
@@ -415,7 +415,7 @@ def _verify_cert_link(self, current_cert, next_cert):
415415
except cryptography.exceptions.InvalidSignature:
416416
raise CertificateChainBroken(current_cert, next_cert)
417417
else:
418-
raise CertificateUnknownPublicKey(current_cert, key)
418+
raise CertificateUnsupportedKeyType(current_cert, key)
419419

420420
def _check_name_constraints(self, current_cert, next_cert):
421421
try:

tests/test_autograph_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ async def test_unknown_key(aiohttp_session, mock_with_x5u, cache, now_fixed):
321321
with mock.patch("cryptography.x509.load_pem_x509_certificate") as load_cert_mock:
322322
load_cert_mock.side_effect = lambda *args, **kwargs: certs.pop(0)
323323
s = SignatureVerifier(aiohttp_session, cache, DEV_ROOT_HASH)
324-
with pytest.raises(autograph_utils.CertificateUnknownPublicKey) as excinfo:
324+
with pytest.raises(autograph_utils.CertificateUnsupportedKeyType) as excinfo:
325325
await s.verify_x5u(FAKE_CERT_URL)
326326

327327
assert excinfo.value.cert == mock_intermediate

0 commit comments

Comments
 (0)