Skip to content

Commit a160653

Browse files
olaservocliffhall
andauthored
Apply suggestions from code review
Co-authored-by: Cliff Hall <cliff@futurescale.com>
1 parent c20c017 commit a160653

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

src/everything/docs/features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ MCP Tasks are bidirectional - both server and client can be task executors:
9696
| Server -> Client | `elicitation/create` | Client | `trigger-elicitation-request-async` |
9797

9898
For client-side tasks:
99-
1. Server sends request with task metadata (e.g., `_meta.task.ttl`)
99+
1. Server sends request with task metadata (e.g., `params.task.ttl`)
100100
2. Client creates task and returns `CreateTaskResult` with `taskId`
101101
3. Server polls `tasks/get` for status updates
102102
4. When complete, server calls `tasks/result` to retrieve the result

src/everything/tools/trigger-elicitation-request-async.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ export const registerTriggerElicitationRequestAsyncTool = (server: McpServer) =>
5353
const request = {
5454
method: "elicitation/create" as const,
5555
params: {
56+
task: {
57+
ttl: 600000, // 10 minutes (user input may take a while)
58+
pollInterval: POLL_INTERVAL,
59+
},
5660
message: "Please provide inputs for the following fields (async task demo):",
5761
requestedSchema: {
5862
type: "object" as const,
@@ -76,12 +80,6 @@ export const registerTriggerElicitationRequestAsyncTool = (server: McpServer) =>
7680
},
7781
required: ["name"],
7882
},
79-
_meta: {
80-
task: {
81-
ttl: 600000, // 10 minutes (user input may take a while)
82-
pollInterval: POLL_INTERVAL,
83-
},
84-
},
8583
},
8684
};
8785

src/everything/tools/trigger-sampling-request-async.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ export const registerTriggerSamplingRequestAsyncTool = (server: McpServer) => {
6767
const request: CreateMessageRequest & { params: { _meta?: { task: { ttl: number; pollInterval: number } } } } = {
6868
method: "sampling/createMessage",
6969
params: {
70+
task: {
71+
ttl: 300000, // 5 minutes
72+
pollInterval: POLL_INTERVAL,
73+
},
7074
messages: [
7175
{
7276
role: "user",
@@ -79,12 +83,6 @@ export const registerTriggerSamplingRequestAsyncTool = (server: McpServer) => {
7983
systemPrompt: "You are a helpful test server.",
8084
maxTokens,
8185
temperature: 0.7,
82-
_meta: {
83-
task: {
84-
ttl: 300000, // 5 minutes
85-
pollInterval: POLL_INTERVAL,
86-
},
87-
},
8886
},
8987
};
9088

0 commit comments

Comments
 (0)