polish smoke test

Author: mlin

.pre-commit-config.yaml

@@ -37,4 +37,4 @@ repos:
     files: \.py$
     verbose: true
     entry: env PYTHONPATH=bindings/python pylint
-    args: [-d, "bad-continuation,global-statement,missing-docstring,missing-module-docstring,line-too-long,too-many-arguments,duplicate-code,redefined-outer-name,too-many-locals,bare-except,broad-except,import-outside-toplevel,protected-access"]
+    args: [-d, "bad-continuation,global-statement,missing-docstring,missing-module-docstring,line-too-long,too-many-arguments,duplicate-code,redefined-outer-name,too-many-locals,bare-except,broad-except,import-outside-toplevel,protected-access,too-many-statements"]

CMakeLists.txt

@@ -49,7 +49,7 @@ add_subdirectory(loaders)
 if(CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)
     include(CTest)
     enable_testing()
-    set(GENOMICSQLITE_TEST_ENV env PYTHONPATH=$PYTHONPATH:${CMAKE_CURRENT_SOURCE_DIR}/bindings/python LD_LIBRARY_PATH=$LD_LIBRARY_PATH:${CMAKE_BINARY_DIR} GENOMICSQLITE_SYSTEM_LIBRARY=1)
+    set(GENOMICSQLITE_TEST_ENV env PYTHONPATH=${CMAKE_CURRENT_SOURCE_DIR}/bindings/python:${PYTHONPATH} LD_LIBRARY_PATH=${CMAKE_BINARY_DIR}:${LD_LIBRARY_PATH} GENOMICSQLITE_SYSTEM_LIBRARY=1)
     add_test(NAME smoketest COMMAND ${GENOMICSQLITE_TEST_ENV} python3 ${CMAKE_CURRENT_SOURCE_DIR}/test/genomicsqlite_smoke_test.py)
     add_test(NAME pytest COMMAND ${GENOMICSQLITE_TEST_ENV} python3 -m pytest -xv -n 4 --tb=short ${CMAKE_CURRENT_SOURCE_DIR}/test)
 endif()

bindings/python/genomicsqlite/__init__.py

@@ -21,7 +21,7 @@
         _DLL = os.path.join(_HERE, "libgenomicsqlite.so")
 if not _DLL:
     _DLL = find_library("genomicsqlite")
-assert _DLL, "Unable to locate genomicsqlite shared-library file"
+assert _DLL, "Unable to locate a suitable genomicsqlite shared-library file"
 # open a dummy connection to :memory: just for loading the extension.
 _MEMCONN = sqlite3.connect(":memory:")
 _MEMCONN.enable_load_extension(True)

test/genomicsqlite_smoke_test.py

@@ -38,7 +38,13 @@ def main():
     print(next(conn.execute("SELECT sqlite_version()"))[0])
 
     print("genomicsqlite: ", end="")
-    import genomicsqlite
+    try:
+        import genomicsqlite
+    except ImportError as exn:
+        print(f"\n\nUnable to import genomicsqlite: {exn}")
+        print("The Python genomicsqlite package may need to be installed via pip3 or conda,")
+        print("or its location may need to be added to PYTHONPATH.")
+        sys.exit(1)
 
     print(genomicsqlite.__version__)
     print(f"genomicsqlite library: {genomicsqlite._DLL}")
@@ -103,7 +109,7 @@ def main():
                 "** Please redirect this log to a file and send to maintainers @ https://github.com/mlin/GenomicSQLite\n"
             )
 
-            sys.exit(1)
+            sys.exit(2)
 
         dbconn.close()
         print("\n ✓ GenomicSQLite smoke test OK\n")
@@ -475,4 +481,4 @@ def main():
 except Exception:
     print()
     traceback.print_exc(file=sys.stdout)
-    sys.exit(2)
+    sys.exit(1)