fix page reclaims

Author: mirsella

perf.data

@@ -21,22 +21,22 @@ void _free(void *ptr) {
     alloc->parent->alloc = alloc->next;
 
   // in case it's the only alloc in a t_mmap, free the mmap
-  if (!alloc->next && !alloc->prev && alloc->parent->type == LARGE) {
+  // and only if there is still a t_mmap in g_mmap
+  if (!alloc->next && !alloc->prev &&
+      (g_mmap->next || alloc->parent->type == LARGE)) {
     t_mmap *map = alloc->parent;
     if (map->prev)
       map->prev->next = map->next;
     if (map->next)
       map->next->prev = map->prev;
-    // FIX: this cause page reclaims to skyrocket
+    // WARN: this cause minor page faults (page reclaims) to skyrocket
     if (map == g_mmap)
       g_mmap = map->next;
     munmap(map, map->size + sizeof(t_mmap));
   }
 }
 
 void free(void *ptr) {
-  (void)ptr;
-  /* return; */
   if (LOGGING) {
     ft_dprintf(tmpfd(), "free(%p)\n", ptr);
     /* flog("free(): ", (size_t)ptr); */

src/free.c

@@ -28,36 +28,11 @@ int main() {
   assert(strcmp(dynstr, "Test1234") == 0);
   free(dynstr);
 
-  // 2. Memory integrity tests
-  int *numbers = (int *)malloc(10 * sizeof(int));
-  assert(numbers != NULL);
-  for (int i = 0; i < 10; i++) {
-    numbers[i] = i;
-  }
-  for (int i = 0; i < 10; i++) {
-    assert(numbers[i] == i);
-  }
-  free(numbers);
-
-  char *buf1 = (char *)malloc(100);
-  char *buf2 = (char *)malloc(100);
-  for (int i = 0; i < 100; i++) {
-    buf1[i] = 1;
-    buf2[i] = 2;
-  }
-  for (int i = 0; i < 100; i++) {
-    assert(buf1[i] == 1);
-    assert(buf2[i] == 2);
-  }
-  free(buf1);
-  free(buf2);
-
-  // 3. Edge cases
   void *edge1 = malloc(0);
-  free(edge1); // This should not crash
+  free(edge1);
 
   char *edge2 = (char *)malloc(5);
-  edge2 = realloc(edge2, 0); // This should behave as free
+  edge2 = realloc(edge2, 0);
   assert(edge2 == NULL);
 
   ft_printf("All tests passed!\n");