StreamClient: explode headers by ':' only (without space)

milo · milo · commit ec5a8ae08a9d · 2014-10-01T10:27:49.000+02:00
Some developer local proxies modifies spaces around semicolon. It is allowed by RFC2616. One space is only recomended.
diff --git a/src/Github/Http/StreamClient.php b/src/Github/Http/StreamClient.php
@@ -103,8 +103,8 @@ protected function fileGetContents($url, array $contextOptions)
 
 		$headers = [];
 		foreach ($http_response_header as $header) {
-			list($name, $value) = explode(': ', $header, 2) + [NULL, NULL];
-			$headers[$name] = $value;
+			list($name, $value) = explode(':', $header, 2) + [NULL, NULL];
+			$headers[trim($name)] = trim($value);
 		}
 
 		return [$m[1], $headers, $content];

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,8 @@ protected function fileGetContents($url, array $contextOptions)`
`103`	`103`
`104`	`104`	`$headers = [];`
`105`	`105`	`foreach ($http_response_header as $header) {`
`106`		`- list($name, $value) = explode(': ', $header, 2) + [NULL, NULL];`
`107`		`- $headers[$name] = $value;`
	`106`	`+ list($name, $value) = explode(':', $header, 2) + [NULL, NULL];`
	`107`	`+ $headers[trim($name)] = trim($value);`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`return [$m[1], $headers, $content];`