Http: fix proxy HTTP response [Ref #5]

When SSL request goes throuh the HTTP proxy, proxy uses CONNECT and adds 'HTTP/1.x 200 Connection Established' (and sometimes some headers like Proxy-Agent) before remote response.

StreamClient isn't affected.

Author: milo

src/Github/Http/CurlClient.php

@@ -53,7 +53,7 @@ protected function process(Request $request)
 			$headers[] = "$name: $value";
 		}
 
-		$responseHeaders = NULL;
+		$responseHeaders = [];
 
 		$softOptions = [
 			CURLOPT_CONNECTTIMEOUT => 10,
@@ -74,9 +74,10 @@ protected function process(Request $request)
 			CURLOPT_POSTFIELDS => $request->getContent(),
 			CURLOPT_HEADER => FALSE,
 			CURLOPT_HEADERFUNCTION => function($curl, $line) use (& $responseHeaders) {
-				if ($responseHeaders === NULL) {
+				if (strncasecmp($line, 'HTTP/', 5) === 0) {
+					/** @todo Set proxy response as Response::setPrevious($proxyResponse)? */
+					# The HTTP/x.y may occur multiple times with proxy (HTTP/1.1 200 Connection Established)
 					$responseHeaders = [];
-					# and skip 1st line, it is HTTP code
 
 				} elseif ($line !== "\r\n") {
 					list($name, $value) = explode(':', $line, 2);
@@ -99,16 +100,11 @@ protected function process(Request $request)
 			throw new BadResponseException('Setting cURL options failed: ' . curl_error($this->curl), curl_errno($this->curl));
 		}
 
-		$responseHeaders = NULL;
 		$content = curl_exec($this->curl);
 		if ($content === FALSE) {
 			throw new BadResponseException(curl_error($this->curl), curl_errno($this->curl));
 		}
 
-		if (!is_array($responseHeaders)) {
-			throw new BadResponseException('Response headers were not fetched.');
-		}
-
 		$code = curl_getinfo($this->curl, CURLINFO_HTTP_CODE);
 		if ($code === FALSE) {
 			throw new BadResponseException('HTTP status code is missing:' . curl_error($this->curl), curl_errno($this->curl));