Api: fixed URL parameters escaping

e.g. ' ' => '%20'

Author: milo

src/Github/Api.php

@@ -352,7 +352,7 @@ protected function substituteUrlParameters(& $url, array & $parameters)
 
 			$parameter = $parameters[$m[2]];
 			unset($parameters[$m[2]]);
-			return $m[1] . $parameter;
+			return $m[1] . rawurlencode($parameter);
 		}, $url);
 	}
 

tests/Github/Api.substituteUrlParameters.phpt

@@ -16,7 +16,7 @@ class TestApi extends Milo\Github\Api
 }
 
 
-# substituteUrl()
+# URL parameters like :name
 test(function() {
 	$api = new TestApi;
 
@@ -50,3 +50,16 @@ test(function() {
 		$api->substituteUrlParameters($url, $params);
 	}, 'Milo\Github\MissingParameterException', "Missing parameter 'a:b' for URL path ':a:b'.");
 });
+
+
+# URL parameters like :name with special chars as value
+test(function() {
+	$api = new TestApi;
+
+	$url = '/:name';
+	$params = ['name' => 'with space'];
+	$api->substituteUrlParameters($url, $params);
+
+	Assert::same('/with%20space', $url);
+	Assert::same([], $params);
+});