FileCache: fixed cache directory creation

Author: milo

src/Github/Storages/FileCache.php

@@ -23,12 +23,18 @@ class FileCache extends Github\Sanity implements ICache
 	 */
 	public function __construct($tempDir)
 	{
+		if (!is_dir($tempDir)) {
+			throw new MissingDirectoryException("Directory '$tempDir' is missing.");
+		}
+
 		$dir = $tempDir . DIRECTORY_SEPARATOR . 'milo.github-api';
 
 		if (!is_dir($dir)) {
 			set_error_handler(function($severity, $message, $file, $line) use ($dir, & $valid) {
 				restore_error_handler();
-				throw new MissingDirectoryException("Temporary directory '$dir' is missing.'", 0, new \ErrorException($message, 0, $severity, $file, $line));
+				if (!is_dir($dir)) {
+					throw new MissingDirectoryException("Cannot create '$dir' directory.", 0, new \ErrorException($message, 0, $severity, $file, $line));
+				}
 			});
 			mkdir($dir);
 			restore_error_handler();

tests/Github/Storages/.gitignore

@@ -0,0 +1 @@
+/temp.FileCache

tests/Github/Storages/FileCache.phpt

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * @author  Miloslav Hůla
+ */
+
+require __DIR__ . '/../../bootstrap.php';
+
+
+$e = Assert::exception(function() {
+	new Milo\Github\Storages\FileCache(__DIR__ . DIRECTORY_SEPARATOR . 'non-exists');
+}, 'Milo\Github\Storages\MissingDirectoryException', "Directory '%a%non-exists' is missing.");
+
+Assert::null($e->getPrevious());
+
+
+define('TEMP_DIR', __DIR__ . '/temp.FileCache');
+@mkdir(TEMP_DIR);  # @ = directory may exist
+Tester\Helpers::purge(TEMP_DIR);
+
+$cache = new Milo\Github\Storages\FileCache(TEMP_DIR);
+
+Assert::null($cache->load('undefined'));
+
+$value = $cache->save('key-1', NULL);
+Assert::null($cache->load('key-1'));
+
+$value = $cache->save('key-2', TRUE);
+Assert::true($cache->load('key-2'));
+
+$value = $cache->save('key-3', FALSE);
+Assert::false($cache->load('key-3'));
+
+$value = $cache->save('key-4', []);
+Assert::same([], $cache->load('key-4'));
+
+$value = $cache->save('key-5', [0, 'a', []]);
+Assert::same([0, 'a', []], $cache->load('key-5'));
+
+$value = $cache->save('key-6', new stdClass);
+Assert::equal(new stdClass, $cache->load('key-6'));