copilot comments

Author: Aasim Khan

extensions/mssql/src/models/connectionStore.ts

@@ -694,9 +694,8 @@ export class ConnectionStore {
         let dupeCount = 0;
 
         for (const conn of connResults) {
-            const key = conn.id + "-" + conn.profileSource; // Use both ID and source as key to allow same profile in both lists
-            const storedConn = uniqueConnections.get(key);
-            if (storedConn === undefined || storedConn?.profileSource !== conn.profileSource) {
+            const key = `${conn.id}-${conn.profileSource}`; // Use both ID and source as key to allow same profile in both lists
+            if (!uniqueConnections.has(key)) {
                 uniqueConnections.set(key, conn);
             } else {
                 dupeCount++;

extensions/mssql/src/reactviews/pages/ConnectionDialog/connectionsListContainer.tsx

@@ -159,7 +159,7 @@ export const ConnectionsListContainer = () => {
                         return (
                             <ConnectionCard
                                 connection={connection}
-                                key={"mru" + index}
+                                key={"mru" + connection.id}
                                 actionButton={{
                                     icon: <Delete16Regular />,
                                     onClick: (e) => {
@@ -188,7 +188,7 @@ export const ConnectionsListContainer = () => {
                         return (
                             <ConnectionCard
                                 connection={connection}
-                                key={"saved" + index}
+                                key={"saved" + connection.id}
                                 actionButton={{
                                     icon: <Delete16Regular />,
                                     onClick: (e) => {