fix(http-client-csharp): use name comparison in HasSettingsParameter (#10269)

CSharpType.Equals fails when comparing generated types against
Roslyn-based types from CustomCodeView. Use name comparison since
HasSettingsParameter is only called for custom code constructors.

Update tests to use async compilations with a custom constructor that
takes the settings type, so CustomCodeView is exercised.

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: JoshLove-msft

packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientSettingsProvider.cs

@@ -555,7 +555,7 @@ internal static bool IsStandardParameterType(CSharpType type)
         /// </summary>
         internal bool HasSettingsParameter(ConstructorProvider ctor)
         {
-            return ctor.Signature.Parameters.Any(p => p.Type.Equals(Type));
+            return ctor.Signature.Parameters.Any(p => p.Type.Name == Type.Name);
         }
     }
 }

packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ClientSettingsProviderTests.cs

@@ -1009,10 +1009,6 @@ private static bool IsSettingsConstructor(ConstructorProvider c) =>
         [Test]
         public async Task TestProperties_IncludesCustomConstructorParameters()
         {
-            var singletonField = typeof(ClientOptionsProvider).GetField("_singletonInstance",
-                System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic);
-            singletonField?.SetValue(null, null);
-
             await MockHelpers.LoadMockGeneratorAsync(
                 compilation: async () => await Helpers.GetCompilationFromDirectoryAsync());
 
@@ -1034,10 +1030,6 @@ await MockHelpers.LoadMockGeneratorAsync(
         [Test]
         public async Task TestBindCoreMethod_BindsCustomConstructorParameters()
         {
-            var singletonField = typeof(ClientOptionsProvider).GetField("_singletonInstance",
-                System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic);
-            singletonField?.SetValue(null, null);
-
             await MockHelpers.LoadMockGeneratorAsync(
                 compilation: async () => await Helpers.GetCompilationFromDirectoryAsync());
 
@@ -1058,29 +1050,34 @@ await MockHelpers.LoadMockGeneratorAsync(
         }
 
         [Test]
-        public void TestSettingsType_DoesNotContainSelfReferentialSettingsProperty()
+        public async Task TestSettingsType_DoesNotContainSelfReferentialSettingsProperty()
         {
-            var client = InputFactory.Client("TestClient");
-            var clientProvider = new ClientProvider(client);
-            var settingsProvider = clientProvider.ClientSettings;
+            await MockHelpers.LoadMockGeneratorAsync(
+                compilation: async () => await Helpers.GetCompilationFromDirectoryAsync());
+
+            var client = InputFactory.Client("TestClient", clientNamespace: "SampleNamespace");
+            var clientProvider = ScmCodeModelGenerator.Instance.TypeFactory.CreateClient(client);
+            Assert.IsNotNull(clientProvider);
 
+            var settingsProvider = clientProvider!.ClientSettings;
             Assert.IsNotNull(settingsProvider);
 
-            // The settings type should not have a property named "Settings" that references itself.
-            // This would happen if the generated settings constructor (which takes the settings type
-            // as a parameter) is incorrectly treated as a custom constructor.
             var settingsProperty = settingsProvider!.Properties.FirstOrDefault(p => p.Name == "Settings");
             Assert.IsNull(settingsProperty,
                 "Settings type should not contain a self-referential 'Settings' property");
         }
 
         [Test]
-        public void TestBindCoreMethod_DoesNotBindSettingsParameter()
+        public async Task TestBindCoreMethod_DoesNotBindSettingsParameter()
         {
-            var client = InputFactory.Client("TestClient");
-            var clientProvider = new ClientProvider(client);
-            var settingsProvider = clientProvider.ClientSettings;
+            await MockHelpers.LoadMockGeneratorAsync(
+                compilation: async () => await Helpers.GetCompilationFromDirectoryAsync());
+
+            var client = InputFactory.Client("TestClient", clientNamespace: "SampleNamespace");
+            var clientProvider = ScmCodeModelGenerator.Instance.TypeFactory.CreateClient(client);
+            Assert.IsNotNull(clientProvider);
 
+            var settingsProvider = clientProvider!.ClientSettings;
             Assert.IsNotNull(settingsProvider);
 
             var bindCoreMethod = settingsProvider!.Methods.FirstOrDefault(m => m.Signature.Name == "BindCore");

packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/TestData/ClientSettingsProviderTests/TestBindCoreMethod_DoesNotBindSettingsParameter/TestClient.cs

@@ -0,0 +1,12 @@
+#nullable disable
+
+using System.Diagnostics.CodeAnalysis;
+
+namespace SampleNamespace
+{
+    public partial class TestClient
+    {
+        [Experimental("SCME0002")]
+        public TestClient(TestClientSettings settings) { }
+    }
+}

packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/TestData/ClientSettingsProviderTests/TestSettingsType_DoesNotContainSelfReferentialSettingsProperty/TestClient.cs

@@ -0,0 +1,12 @@
+#nullable disable
+
+using System.Diagnostics.CodeAnalysis;
+
+namespace SampleNamespace
+{
+    public partial class TestClient
+    {
+        [Experimental("SCME0002")]
+        public TestClient(TestClientSettings settings) { }
+    }
+}