more

Author: Skn0tt

playwright/_impl/_disposable.py

@@ -34,6 +34,9 @@ async def dispose(self) -> None:
             if not is_target_closed_error(e):
                 raise e
 
+    async def close(self) -> None:
+        await self.dispose()
+
     def __repr__(self) -> str:
         return "<Disposable>"
 
@@ -45,5 +48,8 @@ def __init__(self, dispose_fn: Callable[[], Awaitable[None]]) -> None:
     async def dispose(self) -> None:
         await self._dispose_fn()
 
+    async def close(self) -> None:
+        await self.dispose()
+
     def __repr__(self) -> str:
         return "<Disposable>"

playwright/async_api/_generated.py

@@ -63,7 +63,6 @@
 from playwright._impl._debugger import Debugger as DebuggerImpl
 from playwright._impl._dialog import Dialog as DialogImpl
 from playwright._impl._disposable import Disposable as DisposableImpl
-from playwright._impl._disposable import DisposableStub
 from playwright._impl._download import Download as DownloadImpl
 from playwright._impl._element_handle import ElementHandle as ElementHandleImpl
 from playwright._impl._errors import Error
@@ -8886,7 +8885,7 @@ async def add_style_tag(
 
     async def expose_function(
         self, name: str, callback: typing.Callable
-    ) -> "Disposable":
+    ) -> "AsyncContextManager":
         """Page.expose_function
 
         The method adds a function called `name` on the `window` object of every frame in the page. When called, the
@@ -8943,7 +8942,7 @@ async def main():
 
         Returns
         -------
-        Disposable
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -8958,7 +8957,7 @@ async def expose_binding(
         callback: typing.Callable,
         *,
         handle: typing.Optional[bool] = None,
-    ) -> "Disposable":
+    ) -> "AsyncContextManager":
         """Page.expose_binding
 
         The method adds a function called `name` on the `window` object of every frame in this page. When called, the
@@ -9016,7 +9015,7 @@ async def main():
 
         Returns
         -------
-        Disposable
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -9554,7 +9553,7 @@ async def add_init_script(
         script: typing.Optional[str] = None,
         *,
         path: typing.Optional[typing.Union[pathlib.Path, str]] = None,
-    ) -> "Disposable":
+    ) -> "AsyncContextManager":
         """Page.add_init_script
 
         Adds a script which would be evaluated in one of the following scenarios:
@@ -9587,7 +9586,7 @@ async def add_init_script(
 
         Returns
         -------
-        Disposable
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -9603,7 +9602,7 @@ async def route(
         ],
         *,
         times: typing.Optional[int] = None,
-    ) -> "DisposableStub":
+    ) -> "AsyncContextManager":
         """Page.route
 
         Routing provides the capability to modify network requests that are made by a page.
@@ -9674,7 +9673,7 @@ async def handle_route(route: Route):
 
         Returns
         -------
-        DisposableStub
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -13328,7 +13327,7 @@ async def add_init_script(
         script: typing.Optional[str] = None,
         *,
         path: typing.Optional[typing.Union[pathlib.Path, str]] = None,
-    ) -> "Disposable":
+    ) -> "AsyncContextManager":
         """BrowserContext.add_init_script
 
         Adds a script which would be evaluated in one of the following scenarios:
@@ -13361,7 +13360,7 @@ async def add_init_script(
 
         Returns
         -------
-        Disposable
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -13374,7 +13373,7 @@ async def expose_binding(
         callback: typing.Callable,
         *,
         handle: typing.Optional[bool] = None,
-    ) -> "Disposable":
+    ) -> "AsyncContextManager":
         """BrowserContext.expose_binding
 
         The method adds a function called `name` on the `window` object of every frame in every page in the context. When
@@ -13430,7 +13429,7 @@ async def main():
 
         Returns
         -------
-        Disposable
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -13441,7 +13440,7 @@ async def main():
 
     async def expose_function(
         self, name: str, callback: typing.Callable
-    ) -> "Disposable":
+    ) -> "AsyncContextManager":
         """BrowserContext.expose_function
 
         The method adds a function called `name` on the `window` object of every frame in every page in the context. When
@@ -13497,7 +13496,7 @@ async def main():
 
         Returns
         -------
-        Disposable
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -13515,7 +13514,7 @@ async def route(
         ],
         *,
         times: typing.Optional[int] = None,
-    ) -> "DisposableStub":
+    ) -> "AsyncContextManager":
         """BrowserContext.route
 
         Routing provides the capability to modify network requests that are made by any page in the browser context. Once
@@ -13580,7 +13579,7 @@ async def handle_route(route: Route):
 
         Returns
         -------
-        DisposableStub
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -15716,7 +15715,7 @@ async def stop(
 
     async def group(
         self, name: str, *, location: typing.Optional[TracingGroupLocation] = None
-    ) -> "DisposableStub":
+    ) -> "AsyncContextManager":
         """Tracing.group
 
         **NOTE** Use `test.step` instead when available.
@@ -15745,7 +15744,7 @@ async def group(
 
         Returns
         -------
-        DisposableStub
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -21602,7 +21601,7 @@ async def start(
         on_frame: typing.Optional[
             typing.Callable[[OnFrame], typing.Awaitable[typing.Any]]
         ] = None,
-    ) -> "DisposableStub":
+    ) -> "AsyncContextManager":
         """Screencast.start
 
         Starts the screencast. When `path` is provided, it saves video recording to the specified file. When `onFrame` is
@@ -21621,7 +21620,7 @@ async def start(
 
         Returns
         -------
-        DisposableStub
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -21649,7 +21648,7 @@ async def show_actions(
             ]
         ] = None,
         font_size: typing.Optional[int] = None,
-    ) -> "DisposableStub":
+    ) -> "AsyncContextManager":
         """Screencast.show_actions
 
         Enables visual annotations on interacted elements. Returns a disposable that stops showing actions when disposed.
@@ -21665,7 +21664,7 @@ async def show_actions(
 
         Returns
         -------
-        DisposableStub
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -21684,7 +21683,7 @@ async def hide_actions(self) -> None:
 
     async def show_overlay(
         self, html: str, *, duration: typing.Optional[float] = None
-    ) -> "DisposableStub":
+    ) -> "AsyncContextManager":
         """Screencast.show_overlay
 
         Adds an overlay with the given HTML content. The overlay is displayed on top of the page until removed. Returns a
@@ -21700,7 +21699,7 @@ async def show_overlay(
 
         Returns
         -------
-        DisposableStub
+        AsyncContextManager
         """
 
         return mapping.from_impl(
@@ -21755,7 +21754,7 @@ async def hide_overlays(self) -> None:
 mapping.register(ScreencastImpl, Screencast)
 
 
-class Disposable(AsyncBase):
+class Disposable(AsyncContextManager):
 
     async def dispose(self) -> None:
         """Disposable.dispose
@@ -21766,5 +21765,9 @@ async def dispose(self) -> None:
 
         return mapping.from_maybe_impl(await self._impl_obj.dispose())
 
+    async def close(self) -> None:
+
+        return mapping.from_maybe_impl(await self._impl_obj.close())
+
 
 mapping.register(DisposableImpl, Disposable)