Update ccb label/icon in updateState (#2164) (#2166)

* update label/icon every time

* pr update

* turn xcuitest back on

Author: joannaquu

Demos/FluentUIDemo_iOS/FluentUIDemoTests/CommandBarTest.swift

@@ -28,7 +28,7 @@ class CommandBarTest: BaseTest {
 
     // ensures that tapping on text style button rotates through text styles
     func testChangeTextStyleButton() throws {
-        let textStyleButtonNumber: Int = 15
+        let textStyleButtonNumber: Int = 16
         let textStyleButton: XCUIElement = app.buttons.element(boundBy: textStyleButtonNumber)
 
         XCTAssert(app.buttons["Body"].exists)

Sources/FluentUI_iOS/Components/Command Bar/CommandBarButton.swift

@@ -48,8 +48,6 @@ class CommandBarButton: UIButton {
             isAccessibilityElement = false
         } else {
             var buttonConfiguration = UIButton.Configuration.plain()
-            buttonConfiguration.title = item.title
-            buttonConfiguration.image = item.iconImage
             buttonConfiguration.imagePadding = CommandBarTokenSet.buttonImagePadding
             buttonConfiguration.contentInsets = CommandBarTokenSet.buttonContentInsets
             buttonConfiguration.background.cornerRadius = 0
@@ -89,6 +87,9 @@ class CommandBarButton: UIButton {
             return
         }
 
+        configuration?.title = item.title
+        configuration?.image = item.iconImage
+
         if let font = item.titleFont {
             let attributeContainer = AttributeContainer([NSAttributedString.Key.font: font])
             configuration?.attributedTitle?.setAttributes(attributeContainer)